From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Daniel Thompson <daniel@riscstar.com>,
Alex Elder <elder@riscstar.com>,
Davide Caratti <dcaratti@redhat.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 2/3] net: stmmac: add tc-mqprio qdisc offload
Date: Fri, 14 Aug 2026 13:56:31 -0700 [thread overview]
Message-ID: <20260814135631.766ceb41@kernel.org> (raw)
In-Reply-To: <20260808-stmmac-ets-offload-v3-2-b714466142b9@oss.qualcomm.com>
On Sat, 08 Aug 2026 16:49:58 +0200 Lorenzo Bianconi wrote:
> Subject: [PATCH net-next v3 2/3] net: stmmac: add tc-mqprio qdisc offload
>
> Implement offload of the tc-mqprio qdisc in the stmmac driver. The MTL TX
> scheduler is switched to strict priority, and the PSTQX/PSTC priority
> bitmask of each TX queue is programmed from the set of frame priorities
> mapped to the owning traffic class (qopt->prio_tc_map).
>
> The offload requires the DCB feature and a 1:1 TC to TX queue mapping,
> with the queue ranges bounded by the number of queues the MAC implements.
> Configurations with AVB queues are rejected, since forcing strict
> priority conflicts with the CBS algorithm.
Clashiko has a bunch of comments, I assume at least one of them is
actionable. High level - you say "add tc-mqprio qdisc offload"
but the driver already has a bunch of mqprio code. Background
would be useful. You also say "1:1 TC to TX queue mapping", if there's
only one queue per priority why offload mqprio and not prio?
At least a note in the commit message would be useful.
next prev parent reply other threads:[~2026-08-14 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 14:49 [PATCH net-next v3 0/3] Implement mqprio and ets qdisc offload in stmmac driver Lorenzo Bianconi
2026-08-08 14:49 ` [PATCH net-next v3 1/3] net: stmmac: add tc-ets qdisc offload Lorenzo Bianconi
2026-08-08 14:49 ` [PATCH net-next v3 2/3] net: stmmac: add tc-mqprio " Lorenzo Bianconi
2026-08-14 20:56 ` Jakub Kicinski [this message]
2026-08-08 14:49 ` [PATCH net-next v3 3/3] net: stmmac: hold runtime PM reference in setup_tc Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814135631.766ceb41@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel@riscstar.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=elder@riscstar.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.