Re: [PATCH v5 03/10] dt-bindings: gpu: host1x: Document memory-regions for NVDEC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing `memory-region` and `memory-region-names` properties in `nvidia,tegra210-nvdec.yaml`
- [Low] Missing word in the commit message sentence describing NVDEC behavior
--

--- Patch [3]: [PATCH v5 03/10] dt-bindings: gpu: host1x: Document memory-regions for NVDEC ---
commit d7576d345a96bd859ab402d685153853ecaa3898
Author: Thierry Reding <treding@nvidia.com>

dt-bindings: gpu: host1x: Document memory-regions for NVDEC

This commit documents the memory-region and memory-region-names properties
for NVDEC in the nvidia,tegra234-nvdec.yaml schema. It specifies a reference
to the video protection memory region used for secure video playback.

> The video protection region is a reserved memory region that can be used
> for secure video playback. NVDEC can access this region to decode images
> into securely.

[Severity: Low]
This isn't a bug, but there seems to be a missing word in the commit message.
Should this be "decode images into it securely"?

> diff --git a/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml b/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
> index 0b7561c8b9bb2..72313f776dbd8 100644
> --- a/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
> +++ b/Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra234-nvdec.yaml
> @@ -60,6 +60,14 @@ properties:
>        - const: dma-mem
>        - const: write
>  
> +  memory-region:
> +    items:
> +      - description: reference to the video protection memory region
> +
> +  memory-region-names:
> +    items:
> +      - const: protected
> +

[Severity: Medium]
Will this same feature be used on older hardware variants?

The Video Protection Region (VPR) appears to be available on older Tegra
devices as well. Since the schema located at
Documentation/devicetree/bindings/gpu/host1x/nvidia,tegra210-nvdec.yaml
uses additionalProperties: false, attempting to configure the VPR on older
NVDEC nodes will fail schema validation.

Should memory-region and memory-region-names be added to
nvidia,tegra210-nvdec.yaml too?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814-tegra-vpr-v5-0-71832b5d0246@nvidia.com?part=3