From: Greg KH <gregkh@linuxfoundation.org>
To: luoxueqin <luoxueqin@kylinos.cn>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
pooja.katiyar@intel.com, johan@kernel.org, pmenzel@molgen.mpg.de,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: ucsi: Add ACPI_COMPANION() NULL check in ucsi_acpi_probe
Date: Fri, 14 Aug 2026 10:35:44 +0900 [thread overview]
Message-ID: <2026081458-payer-pacifier-f4ec@gregkh> (raw)
In-Reply-To: <043577d0-4b42-43c7-be7b-abcedbbffc46@kylinos.cn>
On Thu, Aug 13, 2026 at 11:25:55AM +0800, luoxueqin wrote:
> Hi Heikki,
>
> Thanks for the review.
>
> However, I'd like to point out that this exact issue has been recognized
> as a security vulnerability (CVE-2026-64227), and Rafael already applied
> the same fix pattern to 14 ACPI platform drivers in commit e4865a56d013
> ("ACPI: driver: Check ACPI_COMPANION() against NULL during probe"), which
> is marked for stable backport.
>
> The NULL pointer dereference triggers a kernel oops/panic - a full system
> crash - not just a silent failure. Returning -ENODEV is the correct and
> graceful behavior, consistent with all other drivers fixed in that commit.
Yes, but it requires root to cause this crash, right? Which probably
means that other CVE should be rejected?
As this is a manual bind command, if that ever breaks, you get to keep
the pieces. We don't "defend" for that in the kernel.
thanks,
greg k-h
prev parent reply other threads:[~2026-08-14 1:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 9:58 [PATCH v2] usb: typec: ucsi: Add ACPI_COMPANION() NULL check in ucsi_acpi_probe Xueqin Luo
2026-08-12 9:37 ` Heikki Krogerus
2026-08-13 3:25 ` luoxueqin
2026-08-14 1:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026081458-payer-pacifier-f4ec@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luoxueqin@kylinos.cn \
--cc=pmenzel@molgen.mpg.de \
--cc=pooja.katiyar@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.