From: SJ Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SJ Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
enze.li@gmx.com
Subject: Re: [PATCH] mm/damon/stat: avoid iterating targets in damon_stat_sort_regions()
Date: Fri, 14 Aug 2026 17:47:26 -0700 [thread overview]
Message-ID: <20260815004727.83755-1-sj@kernel.org> (raw)
In-Reply-To: <20260814145409.553724-1-lienze@kylinos.cn>
On Fri, 14 Aug 2026 22:54:09 +0800 Enze Li <lienze@kylinos.cn> wrote:
> damon/stat module creates only one target in damon_stat_build_ctx(), and
> the comment in damon_stat_sort_regions() already says so. But the code
> still iterates adaptive_targets with damon_for_each_target(), which is
> needlessly verbose and adds an extra indentation level.
>
> Just use list_first_entry() to grab the single target, with a
> list_empty() check to be safe.
damon_ctx->adaptive_targetes is a private field. DAMON API callers should
access the field using only public API that exposed on damon.h. Let's not do
this.
If the verboseness and the indentation are problems, let's split out the code
to a function.
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-08-15 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 14:54 [PATCH] mm/damon/stat: avoid iterating targets in damon_stat_sort_regions() Enze Li
2026-08-14 15:00 ` sashiko-bot
2026-08-15 0:47 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815004727.83755-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=enze.li@gmx.com \
--cc=lienze@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.