From: Stephen Hemminger <stephen@networkplumber.org>
To: Joshua Washington <joshwash@google.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 00/14] Introduce RTE_DIV_ROUND_UP
Date: Sat, 15 Aug 2026 08:32:37 -0700 [thread overview]
Message-ID: <20260815083237.5a6d5fae@phoenix.local> (raw)
In-Reply-To: <20260813172241.964736-1-joshwash@google.com>
On Thu, 13 Aug 2026 10:22:25 -0700
Joshua Washington <joshwash@google.com> wrote:
> Numerous drivers independently define the DIV_ROUND_UP macro, using the
> same definition. Attempt to commonize by introducing RTE_DIV_ROUND_UP to
> rte_common.h and replacing usages of DIV_ROUND_UP with RTE_DIV_ROUND_UP.
>
> Changes in v2:
> - Split single patch into series.
>
> Joshua Washington (14):
> eal: introduce division round up macro
> net/i40e: use common division round up macro
> net/idpf: use common division round up macro
> net/ice: use common division round up macro
> net/qede: use common division round up macro
> net/rnp: use common division round up macro
> net/hns3: use common division round up macro
> net/hinic: use common division round up macro
> net/bnx2x: use common division round up macro
> net/cxgbe: use common division round up macro
> net/ena: use common division round up macro
> raw/ifpga/base: use common division round up macro
> drivers: use common division round up macro
> app/procinfo: use common division round up macro
>
> app/proc-info/main.c | 3 +--
> drivers/common/nfp/nfp_platform.h | 2 --
> drivers/net/bnx2x/bnx2x.c | 4 ++--
> drivers/net/bnx2x/bnx2x.h | 11 ++++-------
> drivers/net/cxgbe/base/t4_hw.c | 4 ++--
> drivers/net/cxgbe/base/t4vf_hw.c | 10 +++++-----
> drivers/net/cxgbe/cxgbe_compat.h | 3 +--
> drivers/net/cxgbe/cxgbe_filter.c | 6 +++---
> drivers/net/cxgbe/cxgbe_ofld.h | 4 ++--
> drivers/net/cxgbe/sge.c | 14 +++++++-------
> drivers/net/ena/base/ena_eth_com.h | 4 ++--
> drivers/net/ena/base/ena_plat_dpdk.h | 1 -
> drivers/net/hinic/base/hinic_compat.h | 5 +----
> drivers/net/hns3/hns3_ethdev.h | 2 --
> drivers/net/hns3/hns3_fdir.c | 2 +-
> drivers/net/hns3/hns3_regs.c | 8 ++++----
> drivers/net/hns3/hns3_rss.c | 8 ++++----
> drivers/net/intel/i40e/base/i40e_osdep.h | 3 +--
> drivers/net/intel/ice/base/ice_osdep.h | 3 +--
> drivers/net/intel/idpf/base/idpf_osdep.h | 3 +--
> drivers/net/nfp/nfdk/nfp_nfdk.h | 5 +++--
> drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 3 ++-
> drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +-
> drivers/net/qede/base/bcm_osal.h | 2 --
> drivers/net/qede/base/ecore_chain.h | 2 +-
> drivers/net/qede/base/ecore_cxt.c | 20 +++++++++++---------
> drivers/net/qede/base/ecore_init_fw_funcs.c | 21 ++++++++++++---------
> drivers/net/qede/base/ecore_mcp.c | 6 +++---
> drivers/net/qede/qede_debug.c | 16 ++++++++--------
> drivers/net/rnp/base/rnp_osdep.h | 5 ++---
> drivers/net/rnp/rnp_rxtx.c | 2 +-
> drivers/raw/ifpga/base/opae_osdep.h | 3 +--
> lib/eal/include/rte_common.h | 5 +++++
> 33 files changed, 92 insertions(+), 100 deletions(-)
>
Looks good, the only feedback from AI runs were noise
about blank lines etc.
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2026-08-15 15:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 22:30 [PATCH] eal: introduce division round up macro Joshua Washington
2026-08-13 1:29 ` Stephen Hemminger
2026-08-13 17:22 ` [PATCH v2 00/14] Introduce RTE_DIV_ROUND_UP Joshua Washington
2026-08-13 17:22 ` [PATCH v2 01/14] eal: introduce division round up macro Joshua Washington
2026-08-13 17:22 ` [PATCH v2 02/14] net/i40e: use common " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 03/14] net/idpf: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 04/14] net/ice: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 05/14] net/qede: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 06/14] net/rnp: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 07/14] net/hns3: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 08/14] net/hinic: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 09/14] net/bnx2x: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 10/14] net/cxgbe: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 11/14] net/ena: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 12/14] raw/ifpga/base: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 13/14] drivers: " Joshua Washington
2026-08-13 17:22 ` [PATCH v2 14/14] app/procinfo: " Joshua Washington
2026-08-15 15:32 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815083237.5a6d5fae@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=joshwash@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.