From: Ismail Tarim <ismailtarim7@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Cc: Jing Cai <jing.cai@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Chris Lu <chris.lu@mediatek.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Ismail Tarim <ismailtarim7@gmail.com>
Subject: [PATCH 0/2] Bluetooth: btmtk: fix subsystem reset error reporting
Date: Sat, 15 Aug 2026 14:01:17 +0300 [thread overview]
Message-ID: <20260815110119.11301-1-ismailtarim7@gmail.com> (raw)
Two bugs in btmtk_usb_subsys_reset() that make it report success to its
caller when the subsystem reset has actually failed.
Patch 1 covers the case where the post-reset chip id reads back as zero:
the function logs "Can't get device id, subsys reset fail." and then
returns the (zero) return value of the register read, i.e. success.
Patch 2 restores propagation of the MTK_BT_RST_DONE poll timeout, which
has been silently overwritten since commit 3dcb122b3064 ("Bluetooth:
btusb: mediatek: return error for failed reg access") started assigning
err at the chip id read.
Found while investigating an MT7902 [13d3:3579] whose controller firmware
asserts and never returns to the USB bus. Both patches only correct the
error reporting; neither changes the recovery behaviour or makes that
controller recoverable. They are a prerequisite for anything that wants
to react to a failed reset, since today the failure is not visible to
the caller.
Compile tested on x86_64 (W=1, no new warnings); checkpatch --strict clean.
Ismail Tarim (2):
Bluetooth: btmtk: Fix btmtk_usb_subsys_reset() reporting success on
failure
Bluetooth: btmtk: Do not discard the subsystem reset timeout
drivers/bluetooth/btmtk.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
base-commit: 15ef2f78c49d20d53ec7c0f1c9b40b02e089f2d6
--
2.55.0
next reply other threads:[~2026-08-15 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 11:01 Ismail Tarim [this message]
2026-08-15 11:01 ` [PATCH 1/2] Bluetooth: btmtk: Fix btmtk_usb_subsys_reset() reporting success on failure Ismail Tarim
2026-08-15 11:35 ` Bluetooth: btmtk: fix subsystem reset error reporting bluez.test.bot
2026-08-15 11:01 ` [PATCH 2/2] Bluetooth: btmtk: Do not discard the subsystem reset timeout Ismail Tarim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815110119.11301-1-ismailtarim7@gmail.com \
--to=ismailtarim7@gmail.com \
--cc=chris.lu@mediatek.com \
--cc=jing.cai@mediatek.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.