All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
	yuyang.du@intel.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	syzbot+8753715f05759f1a10de@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] usbip: vhci_hcd: let the driver core manage the sysfs attributes
Date: Sun, 16 Aug 2026 08:56:22 +0200	[thread overview]
Message-ID: <2026081602-cork-molecule-fd5e@gregkh> (raw)
In-Reply-To: <CADhLXY7UWkd_4wNVSjxQYOVP3GeBZcDA5iiOBoZbz9DXn993GA@mail.gmail.com>

On Sun, Aug 16, 2026 at 11:41:41AM +0530, Deepanshu Kartikey wrote:
> On Sun, Aug 16, 2026 at 10:26 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> 
> > >  extern struct vhci *vhcis;
> > >  extern struct attribute_group vhci_attr_group;
> >
> > Is this still needed here?  And can't it be static now?
> >
> > > @@ -1565,9 +1546,12 @@ static int __init vhci_hcd_init(void)
> > >
> > >       return 0;
> > >
> > > +
> >
> > Extra line?
> >
> > thanks,
> >
> > greg k-h
> 
> I have sent patch v3

Please slow down, there is no rush here, you shouldn't be sending
patches more than one every few days.

greg k-h

      reply	other threads:[~2026-08-16  6:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16  1:50 [PATCH v2] usbip: vhci_hcd: let the driver core manage the sysfs attributes Deepanshu Kartikey
2026-08-16  4:55 ` Greg KH
2026-08-16  6:11   ` Deepanshu Kartikey
2026-08-16  6:56     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026081602-cork-molecule-fd5e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=i@zenithal.me \
    --cc=kartikey406@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=syzbot+8753715f05759f1a10de@syzkaller.appspotmail.com \
    --cc=valentina.manea.m@gmail.com \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.