From: sashiko-bot@kernel.org
To: "Tan Siewert" <tan@siewert.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC
Date: Sun, 16 Aug 2026 11:12:09 +0000 [thread overview]
Message-ID: <20260816111210.2441D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260816-ts-x470d4u-v4-1-cd08e78287ec@siewert.io>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The invalid compatible string `asrock,x470d4u-data64-bmc` is improperly added to the dt-bindings UAPI.
--
--- Patch [1]: [PATCH v4 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC ---
commit d0559c4cf1eefd31825e79b49e2443b883b69be6
Author: Tan Siewert <tan@siewert.io>
dt-bindings: arm: aspeed: add ASRock X470D4U BMC
This commit documents ASRock's X470D4U BMC board compatibles in the Aspeed
device tree binding schema.
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -40,6 +40,8 @@ properties:
> - asrock,e3c256d4i-bmc
> - asrock,romed8hm3-bmc
> - asrock,spc621d8hm3-bmc
> + - asrock,x470d4u-bmc
> + - asrock,x470d4u-data64-bmc
[Severity: Low]
Is this compatible string factually correct for ASRock hardware?
The "-data64" suffix is typically used exclusively by Facebook/Meta hardware
to denote a specific 64MB SPI NOR flash layout in OpenBMC (e.g.,
"facebook,wedge400-data64-bmc").
Could this pollute the stable UAPI/dt-binding schema with a fictitious
device configuration for standard ASRock X470D4U hardware?
> - asrock,x570d4u-bmc
> - bytedance,g220a-bmc
> - facebook,cmm-bmc
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260816-ts-x470d4u-v4-0-cd08e78287ec@siewert.io?part=1
next prev parent reply other threads:[~2026-08-16 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 11:05 [PATCH v4 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support Tan Siewert
2026-08-16 11:05 ` [PATCH v4 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC Tan Siewert
2026-08-16 11:12 ` sashiko-bot [this message]
2026-08-16 11:05 ` [PATCH v4 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260816111210.2441D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tan@siewert.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.