All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
Cc: David Rhodes <david.rhodes@cirrus.com>,
	 Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	 Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-sound@vger.kernel.org,  patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties
Date: Mon, 17 Aug 2026 09:39:20 +0200	[thread overview]
Message-ID: <20260817-brawny-smart-dove-85e4a5@quoll> (raw)
In-Reply-To: <20260814223456.611160-1-rriveram@opensource.cirrus.com>

On Fri, Aug 14, 2026 at 10:34:52PM +0000, Ricardo Rivera-Matos wrote:
> Introduces support for the multidevice synchronization (SYNC)
> bus. The properties introduced allow for the configuration
> of the device's transmitter IDs.
> 
> Signed-off-by: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
> ---
>  .../bindings/sound/cirrus,cs35l45.yaml        | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)

Sashiko comments are valid.

> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> index 70f6c62aedca..f64ba8c872b9 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> @@ -53,6 +53,29 @@ properties:
>      maximum: 3
>      default: 2
>  
> +  sync:
> +    description:
> +      Multidevice synchronization (SYNC) bus configuration
> +    type: object
> +    additionalProperties: false
> +    properties:
> +      cirrus,sync-lsw-txid:
> +        description: |

Do not need '|' unless you need to preserve formatting.

> +          Transmitter ID to use for long software (LSW) data packets
> +          on the SYNC bus.
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 7
> +        default: 0
> +      cirrus,sync-sw-txid:
> +        description: |
> +          Transmitter ID to use for short software (SW) data packets
> +          on the SYNC bus.

What is transmitter ID? Why does it differ per board designs?

Best regards,
Krzysztof


  parent reply	other threads:[~2026-08-17  7:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 22:34 [PATCH v2 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties Ricardo Rivera-Matos
2026-08-14 22:34 ` [PATCH v2 2/2] ASoC: cs35l45: Adds support for SYNC bus Ricardo Rivera-Matos
2026-08-14 22:41   ` sashiko-bot
2026-08-17 14:07     ` Ricardo Rivera-Matos
2026-08-17 17:37   ` Mark Brown
2026-08-17 19:33     ` Ricardo Rivera-Matos
2026-08-14 22:34 ` [PATCH v2 0/2] Introduces MDSYNC support for CS35L45 Ricardo Rivera-Matos
2026-08-14 22:40 ` [PATCH v2 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties sashiko-bot
2026-08-17  7:39 ` Krzysztof Kozlowski [this message]
2026-08-18 13:33   ` Ricardo Rivera-Matos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817-brawny-smart-dove-85e4a5@quoll \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=rriveram@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.