From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Ren Wei <weir@nebusec.ai>,
edumazet@google.com, ncardwell@google.com,
netdev@vger.kernel.org, dsahern@kernel.org, davem@davemloft.net,
pabeni@redhat.com, horms@kernel.org, vega@nebusec.ai,
edragain@163.com
Subject: Re: [PATCH net RESEND 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS
Date: Mon, 17 Aug 2026 09:50:15 -0700 [thread overview]
Message-ID: <20260817095015.75fc2f44@kernel.org> (raw)
In-Reply-To: <20260817082803.GA242453@shredder>
On Mon, 17 Aug 2026 11:28:03 +0300 Ido Schimmel wrote:
> Given the above and the "We assume here that mss >= 1. This MUST be
> enforced by all callers" comment above tcp_select_initial_window(), do
> you prefer to fix this in TCP by enforcing a minimum MSS value?
> Something like [3].
Should we still take the patch as posted?
Maybe not as a fix but to let the user know the value is out of bounds?
next prev parent reply other threads:[~2026-08-17 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 17:05 [PATCH net RESEND 0/1] ipv4: fix divide-by-zero from undersized RTAX_ADVMSS Ren Wei
2026-08-13 17:05 ` [PATCH net RESEND 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS Ren Wei
2026-08-17 8:28 ` Ido Schimmel
2026-08-17 8:35 ` Eric Dumazet
2026-08-17 10:14 ` Ido Schimmel
2026-08-17 14:20 ` Eric Dumazet
2026-08-17 16:50 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-28 5:08 [PATCH net 0/1] ipv4: fix divide-by-zero from undersized RTAX_ADVMSS Ren Wei
2026-08-06 4:13 ` [PATCH net RESEND 1/1] ipv4: reject RTAX_ADVMSS values below TCP_MIN_MSS Ren Wei
2026-08-06 4:13 ` Ren Wei
2026-08-06 14:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817095015.75fc2f44@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edragain@163.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vega@nebusec.ai \
--cc=weir@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.