Re: [PATCH v9 8/9] perf c2c: add function view browser UI and cacheline detail

[sashiko-bot@kernel.org]

> Add the browser front end: create/run/delete the hist_browser and add the
> title. The d shortcut opens the existing per-cacheline detail view for the
> selected level-3 cacheline. Level-3 entries retain the source cacheline
> index, so the shortcut can locate the original entry without relying on a
> potentially ambiguous virtual address.
> 
> Report a warning when the common model rejects a cacheline coalescing field
> list without `iaddr`. Without it, the detail histograms may already have
> merged samples from different functions and cannot support reliable
> function attribution.
> 
> Keep visible-row accounting local to the function view by wrapping the
> generic browser refresh callback and recounting the currently reachable
> hierarchy before each redraw. This keeps navigation correct when a level-1
> row is collapsed while level-3 descendants remain expanded, without adding
> C2C-specific hooks to the shared hist_browser. Also handle Ctrl-C like the
> other function-view exit keys.
> 
> Keep callchains hidden while the function browser runs, restoring the
> user's setting while opening the cacheline detail view.
> 
> Wire the builder into perf_c2c__browse_function_view().
> 
> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817094623.3288456-1-jiebin.sun@intel.com?part=8