From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E66623DB30B; Mon, 17 Aug 2026 13:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974888; cv=none; b=HlwrZFrR5xfaZGe+8qRRFsUZ8g6/77U7mz+fZacSPws03dIyogR44jKePsW6hiYG0FsMYM0Gc3F0UKsYNSVtyG2/ip/dXobvbfQTcvb2WondqIhWZVvk9tIHpW/wd44Gt+zV6p4cjKBiAf/GoN1IbwBtnzc9dpYnNr28pb19qnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974888; c=relaxed/simple; bh=QP53iv2TGlFSEQ8ehMVlEBCEsMJ+NLi1eg4bniGPEcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kp0muX3qNrrOlm7jZzJA4V+lno5JL/NPZKNze0KfMuhCFm0yvjiKsih7E6ufQ6ofYXceQ0UBJ3vN9UZCSlQJeuyle8n5OE8D2iX+6JmgMoDMa5WcXrKc4gxldnAyH+JwRmeCEWvFkgaT5PXA9Kw1mOxrOP5HooIzMV5u2ilu6JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O/p2sClg; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O/p2sClg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72ECA1F00A3A; Mon, 17 Aug 2026 13:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786974882; bh=oHanaXKJePWteGW3dI9poZ0RmPqmUNN38/+OKECU9ck=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=O/p2sClgrr5raeyadetLui2+ULIJgzD057ZJesVjbtgctMBq3cR/A2kYr1hVDSoZd cXb+2Sq4mOxmxqiMtj0WhGqtpIKJ2rLKlmYA0GGGiihVLMxc4DSa/5+t1W9hnOTyOk IgcUc/3fY4NO/uE+xjupgn8YIEss93glz33DKObk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pavan Chebbi , Keegan Freyhof , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.18 088/250] bnxt_en: Fix PTP PPS setting bug Date: Mon, 17 Aug 2026 15:30:49 +0200 Message-ID: <20260817132540.074707132@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132536.466235697@linuxfoundation.org> References: <20260817132536.466235697@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Keegan Freyhof [ Upstream commit 80eaf88efec33ac77ed7726d066c4f2f932cc329 ] The existing driver logic is always turning on PTP_CLK_REQ_PPS regardless of the "on" parameter passed to bnxt_ptp_enable(). During shutdown, PTP_CLK_REQ_PPS may be turned off and this bug will do the opposite and may trigger a PCIe PTM request TLP. On some systems this can trigger a PCIe AER. Fix it by properly configuring PTP_CLK_REQ_PPS based on the "on" parameter. Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins") Reviewed-by: Pavan Chebbi Signed-off-by: Keegan Freyhof Signed-off-by: Michael Chan Link: https://patch.msgid.link/20260731190937.807270-6-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 0abaa2bbe3577..44b7afe9a6f56 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -514,12 +514,15 @@ static int bnxt_ptp_enable(struct ptp_clock_info *ptp_info, return rc; case PTP_CLK_REQ_PPS: /* Configure PHC PPS IN */ - rc = bnxt_ptp_cfg_pin(bp, 0, BNXT_PPS_PIN_PPS_IN); + pin_id = 0; + if (!on) + break; + rc = bnxt_ptp_cfg_pin(bp, pin_id, BNXT_PPS_PIN_PPS_IN); if (rc) return rc; rc = bnxt_ptp_cfg_event(bp, BNXT_PPS_EVENT_INTERNAL); if (!rc) - ptp->pps_info.pins[0].event = BNXT_PPS_EVENT_INTERNAL; + ptp->pps_info.pins[pin_id].event = BNXT_PPS_EVENT_INTERNAL; return rc; default: netdev_err(ptp->bp->dev, "Unrecognized PIN function\n"); -- 2.53.0