From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F392C1594; Mon, 17 Aug 2026 14:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975600; cv=none; b=s0lBOl3IGi0IumrfS/AzXEhAeicI6Yc7WnZ6rJdUnCPJ1EQGVBl937bBZiXZgsnjY1it2umXtph3BlvvnFfFD4zilxmfghyZu44TJ2yQx1glRpbtSV6lxJZGUGHr8jvMgROceegzSPvWd0LX6FK3amKsJ+RbWGtk5n6YPePPKpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975600; c=relaxed/simple; bh=fQIEOWunaDE+u2YDglAjM29SH/gejh1VgaCG/gXPvxk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fnKvQdvz35qM8GYDPM51uNFsda4wPc8vsiEd/urdiXTqiOjplK1GhQFL/sFusieT1H+QC9GoCk3RQ30Bzz/sWmPwNLqfZbD1DxKGC0AM8qN+Xynhn5OQbqChcKz/S6nQfgq/7afu1903zGMTpOnjkWExV2Sq1DBjV3SkK3lsIao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NavFULeA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NavFULeA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4067D1F000E9; Mon, 17 Aug 2026 14:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975598; bh=1ntyUxRBnbQ2Niy/8jumrNvYOQYnJf3Cx75Y0kqVLM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NavFULeA8Z8oDz411z2VMAQntlDbD3GzMmNmNXXyPlVA5Rqj1J82JZmvtIlA5di5A Ps59sJdHu5TlkDCT4SvrS9lcV/CG0vFJZ6eITsUJ8Bbk9qUX/k/siiP/Vs5mt5PpZk 8IfUD1IbWiJP5HObeaQlKoOSKbEaT37Lj3FY19OY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+85d0bec020d805014a3a@syzkaller.appspotmail.com, Helen Koike , Tung Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 084/389] tipc: fix infinite loop in __tipc_nl_compat_dumpit Date: Mon, 17 Aug 2026 15:28:43 +0200 Message-ID: <20260817132542.380829820@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Helen Koike [ Upstream commit 22f8aa35964e8f2ab026578f45befc9605fd1b28 ] cmd->dumpit callback can return a negative errno, causing an infinite loop due to the while(len) condition. As the loop never terminates, genl_mutex is never released, and other tasks waiting on it starve in D state. Check dumpit's return value, propagate it and jump to err_out on error. Reported-by: syzbot+85d0bec020d805014a3a@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=85d0bec020d805014a3a Fixes: d0796d1ef63d ("tipc: convert legacy nl bearer dump to nl compat") Signed-off-by: Helen Koike Reviewed-by: Tung Nguyen Link: https://patch.msgid.link/20260713204940.647668-1-koike@igalia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/tipc/netlink_compat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 6f0c09b6a15315..e94c9ca2924f45 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -223,6 +223,10 @@ static int __tipc_nl_compat_dumpit(struct tipc_nl_compat_cmd_dump *cmd, int rem; len = (*cmd->dumpit)(buf, &cb); + if (len < 0) { + err = len; + goto err_out; + } nlmsg_for_each_msg(nlmsg, nlmsg_hdr(buf), len, rem) { err = nlmsg_parse_deprecated(nlmsg, GENL_HDRLEN, -- 2.53.0