From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1BE843C7BE; Mon, 17 Aug 2026 13:45:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974319; cv=none; b=EwNn1E0N9L+WXpSSl4yWtMPktnIKpOcY8qfyONGhw5QRFS8jwITSfj8d9ZlYUJ9fdgNq5HZQitf9AlSDKvk2Oa9sQhIOW0a8QdAboKjr03X7NMjrAkBLoRCvmBGjVF6cwyIROd1UQ60D170JW/BjNmeC4Qcj6ub/qqJl1sEY8/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974319; c=relaxed/simple; bh=6JJZrIsUnelGMh0Pv3lC7FftYjNZLhyR2W9kKhYAEGo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IFrz7ZSfI5+C5WWk6q0RjvwsEyw2qpJjMO/U2CxVrepmgnFBGnlF7/uUsDbuafw/EXFywEeRe+1due+CEwUlc57U1DW5C5ku21ktuvkJrNES8DCaIra2Gx0xBvCgo13xB+MWcevhztQSLDWSTqrUMtw7bpRZP332wpPaV8IqV6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cGRvpDHO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cGRvpDHO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEAAD1F000E9; Mon, 17 Aug 2026 13:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786974309; bh=nCI3YKrW5yDvm99UUBRG5UmBAzNmL4o/ZOu/vGsx53g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cGRvpDHO6tH9bmaceIyNRY1cN9yaVi9vv3VGmu4Cq7EfyPXUwDxQojcm6LxNm0F0D Fi3htkMl0NU056vFyviUt9m9GCae8WIfsL/Hxp7wkI16porFP0NO3kPT0fBQWl1Lsh TGfFUVbAtYk6At24SkHL4egyQlb0dtz4f34Lmxfk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Philipp David , Aleksandr Loktionov , Dima Ruinskiy , Tony Nguyen , Jakub Kicinski Subject: [PATCH 7.1 160/271] igc: fix netdev not re-attached after resume if interface is down Date: Mon, 17 Aug 2026 15:31:25 +0200 Message-ID: <20260817132543.485839572@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132536.752504388@linuxfoundation.org> References: <20260817132536.752504388@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Philipp David commit b0ce5fd9fabe7c79463cf4602217d4dfeff5b1fd upstream. __igc_resume() calls netif_device_attach() only inside the netif_running() branch, so an interface that was down during suspend is never re-attached on resume. It then stays in the not-present state that __igc_shutdown() set via netif_device_detach(): ethtool reports ENODEV and every attempt to bring the interface up fails the netif_device_present() check in __dev_open() with -ENODEV, silently, since __igc_resume() returns 0. Only reloading the driver recovers the device. This is easy to hit in practice because NetworkManager brings managed interfaces down before sleep unless Wake-on-LAN is configured, making the adapter unusable after every suspend/resume cycle with WoL disabled. Re-attach the netdev on every successful resume, as igb and e1000e do. Fixes: 6f31d6b643a3 ("igc: Refactor runtime power management flow") Cc: stable@vger.kernel.org Signed-off-by: Philipp David Reviewed-by: Aleksandr Loktionov Reviewed-by: Dima Ruinskiy Signed-off-by: Tony Nguyen Link: https://patch.msgid.link/20260804222205.1580328-11-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/igc/igc_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -7585,11 +7585,13 @@ static int __igc_resume(struct device *d err = __igc_open(netdev, true); if (!rpm) rtnl_unlock(); - if (!err) - netif_device_attach(netdev); + if (err) + return err; } - return err; + netif_device_attach(netdev); + + return 0; } static int igc_resume(struct device *dev)