From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A00C3FB7FC; Mon, 17 Aug 2026 14:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975712; cv=none; b=mH/qhbTugkgKu+KdfQoxbkSC3IFeieiqBcd+SjHz70igUcdV75XM91kppLnHWAnBlxkpcPA+KMkv87JHZMtjx+ezI8qPqgfANOz8PBK5eTTAqlTUxaX4E2huuAJcUu0nI6invRXsCj9tHfmqSCUksESKOyWWWbCfmFdicxDzogs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975712; c=relaxed/simple; bh=XyBWr9Z/jjsMLHR2+IfBSawKaBHS6QBXQkHX1kEg2Kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nHuCAL8/xs0QwhfkGcjxa03xNgvLSktvYv845St5J5PglPx+VA8JDDqNlQtuCdACyirPpHH5Oz2HEYts3rJ16VUJmuRn3Qjx4Xk60blohbXgG69pcg4oCPl37jCqnnxSbKdPW5KH6Hm95B8YYmPy/kOrvBEB+SEXFT586k5s/to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aVT5PGRN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aVT5PGRN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494E21F000E9; Mon, 17 Aug 2026 14:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975710; bh=yAv9WvZr0dVUARaSMOQkUvbSPnVK1E/adQZ6Nvy1PJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aVT5PGRNhd0m4sK4gw/G2XltbCZBVcllODzFI+LdM1VlsqZZIOnWalplhZqRK8zCx AW2WzzKc3Kk9zD+Duj389ITDe2iqDuC48jwet1iGtVzALZSrw8BoSLrBvytR4I9BET rExgR08D9gMZZS5/g0T4HdSzLTAQvkUfFv7+o6Zg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Samuel Holland , Andrey Skvortsov , Paul Kocialkowski , Nicolas Dufresne , Hans Verkuil Subject: [PATCH 5.10 123/389] media: cedrus: Fix missing cleanup in error path Date: Mon, 17 Aug 2026 15:29:22 +0200 Message-ID: <20260817132543.954862811@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Samuel Holland commit d99732334aaf33b9f93926b70b6a11c2cef3de39 upstream. According to the documentation struct v4l2_fh has to be cleaned up with v4l2_fh_exit() before being freed. [1] Currently there is no actual bug here, when v4l2_fh_exit() isn't called. v4l2_fh_exit() in this case only destroys internal mutex. But it may change in the future, when v4l2_fh_init/v4l2_fh_exit will be enhanced. 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Cc: stable@vger.kernel.org Acked-by: Paul Kocialkowski Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -332,6 +332,7 @@ static int cedrus_open(struct file *file err_ctrls: v4l2_ctrl_handler_free(&ctx->hdl); err_free: + v4l2_fh_exit(&ctx->fh); kfree(ctx); mutex_unlock(&dev->dev_mutex);