From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863493D3339; Mon, 17 Aug 2026 14:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975743; cv=none; b=JCgyUj8vk8EC8uEknbPMNpI7484dEmb9ei14pUaDHRJFDURE4c5/UPvXqX6+7FKU3WHMzzgfbsuGOfWDdwSaJDgtl89YN4K4BSu8OBJpTPjAJcO0H7n9zzDVja5DUzHZIERIwTRWHR5ueTxgqiv6gReZV74qSHit0lVYse5dplk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975743; c=relaxed/simple; bh=3CvE8oE9MUzuaL9YwQ0TB8wa92lj0galjJqHtPWd3Ko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mdtqbjnTXSz4eAxALD09HcHgxn2al2yMdx0m4RgdzUTAgONa2V0XmC9CJtx2nYHZdjBVytmviZh4VwILBpN7Gcq4iqi/eGak7VuriYLyJTWfMhFtuUXFDX9Uc8RXR/XGoZPwUtOJtRA3j8LsSJ2pSPZ/fdApaWBSdy71ye1ZQls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oix8Z3o5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oix8Z3o5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1D081F000E9; Mon, 17 Aug 2026 14:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975742; bh=VwKjOZzDw0H9UXIIOWjE2BuODn2AUhXlV7FSuzR6qU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oix8Z3o520Msnn/Ybwo2+l9csEiU+aO+nhqY/WQYD6oKeGO7IGV3uYnJ0xdifQVEl Q3ap3eEDzIczX+4xyT0U/Kyg7hvp5KCuajULOhYaRprQ1C8/EE9g0vVFno7ERXrKG0 Pdpn1nelAeKyULWbpwtkwI6kbnyxlnjfxcFeUWKg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+019ced393ab913002b75@syzkaller.appspotmail.com, Deepanshu Kartikey , Hans Verkuil Subject: [PATCH 5.10 133/389] media: rtl2832: fix use-after-free in rtl2832_remove() Date: Mon, 17 Aug 2026 15:29:32 +0200 Message-ID: <20260817132544.341956473@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Deepanshu Kartikey commit 680daf40a82d483949f87f0d8f98639dc47e610c upstream. cancel_delayed_work_sync() is called before i2c_mux_del_adapters() in rtl2832_remove(). While the cancel waits for any running instance of i2c_gate_work to finish, it does not prevent the timer from being rescheduled by a concurrent thread. During probe, the r820t_attach() call attempts I2C transfers through the mux adapter. These transfers go through i2c_mux_master_xfer(), which calls rtl2832_deselect() after the transfer completes, rescheduling i2c_gate_work via schedule_delayed_work(). If this transfer is still in flight when rtl2832_remove() runs, rtl2832_deselect() can reschedule i2c_gate_work after it has been cancelled, causing a use-after-free when kfree(dev) is called. Fix this by calling i2c_mux_del_adapters() before cancel_delayed_work_sync(). Once the mux adapter is unregistered, no new I2C transfers can go through it, so rtl2832_deselect() can no longer reschedule i2c_gate_work. The subsequent cancel_delayed_work_sync() is then guaranteed to be final. Fixes: cddcc40b1b15 ("[media] rtl2832: convert to use an explicit i2c mux core") Cc: stable@vger.kernel.org Reported-by: syzbot+019ced393ab913002b75@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=019ced393ab913002b75 Signed-off-by: Deepanshu Kartikey Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-frontends/rtl2832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/media/dvb-frontends/rtl2832.c +++ b/drivers/media/dvb-frontends/rtl2832.c @@ -1115,10 +1115,10 @@ static int rtl2832_remove(struct i2c_cli dev_dbg(&client->dev, "\n"); - cancel_delayed_work_sync(&dev->i2c_gate_work); - i2c_mux_del_adapters(dev->muxc); + cancel_delayed_work_sync(&dev->i2c_gate_work); + regmap_exit(dev->regmap); kfree(dev);