From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3F0B3033E7; Mon, 17 Aug 2026 14:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975778; cv=none; b=dJ2oshfmKNjsUbawp/LtSlYjVASSgcZw4oEDcfGEh1EuHO2B+VDz/mkcCxGxz4UtWeWuW1skTT9+gSub/rIm1bT+uQ3WMXNN99yIPEbvegyP+taxqtFI8CPdns95H9zNXheAoz7Lzk3OCIZwT1mZ6i3zZ42z7Zh0aa37dEL4L5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975778; c=relaxed/simple; bh=5LlDESllKeiE7kkzBRPqhyZioG83il1DwVfd3BE3oEg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mfMcDXnF+yI5MooViRbJxHDI6m/FGuvlRs/EsRzn6RNIzG+X1z3GMuFYYFTgWU0nHdGhPGit9yiONt9UqxXWs3ic1zfAlemCWRKBzwbMSaaOHM69Sec3jPq0iR2DR/4CDOJg8YqOmA3G/X4F+TRYM28mcvN3iIcY262MKwioAU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oCzGKzEj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oCzGKzEj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 574E61F000E9; Mon, 17 Aug 2026 14:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975776; bh=Dk0DAz9+z5H3t5tQmmWHv+If/Hw2ec7dzJKxmZ74hpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oCzGKzEj7LhQMuQBBGfvaY5PZnSdeocn1TyP+n8/HYKydw05oNft3Aj5ugJV48qil OPM+fDJFKXA51tPprnDY/pQR6mL6oc1zcd6I/FWTaEdLkXc1tXT/q4FOK9Fu3fK/09 Dd/kAXs2/LcG/dU/JchPk+ZuAEHAGmBZD7MDLa5g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Huihui Huang , Johannes Berg Subject: [PATCH 5.10 144/389] wifi: wilc1000: validate assoc response length before subtracting header Date: Mon, 17 Aug 2026 15:29:43 +0200 Message-ID: <20260817132544.779330463@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Huihui Huang commit 4c4c97b60a5e978121d9ee8cb0ab3916e5d6a8de upstream. wilc_parse_assoc_resp_info() computes the trailing IE length as ies_len = buffer_len - sizeof(*res); without first checking that buffer_len is at least sizeof(struct wilc_assoc_resp) (6 bytes). buffer_len is the length reported for a received association response (host_int_parse_assoc_resp_info() passes hif_drv->assoc_resp / assoc_resp_info_len straight in) and must be validated before the driver accesses the fixed header. For a frame shorter than the 6-byte fixed header, the subtraction wraps. For a four-byte response the result is truncated to a u16 ies_len of 65534, so kmemdup() then attempts to copy 65534 bytes starting at buffer + sizeof(*res), beyond the valid association-response data (CWE-125). A response shorter than four bytes can also cause an out-of-bounds read of res->status_code at offsets 2 and 3. Reject frames too short to hold the fixed header before touching the header or computing ies_len. Also set the connection status to a failure on this path: the caller falls through to a "conn_info->status == WLAN_STATUS_SUCCESS" check after the parser returns, so leaving the status untouched could let a malformed short response be treated as a successful association. Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Huihui Huang Link: https://patch.msgid.link/20260714091811.3596126-1-hhhuang@smu.edu.sg Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/microchip/wilc1000/hif.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/wireless/microchip/wilc1000/hif.c +++ b/drivers/net/wireless/microchip/wilc1000/hif.c @@ -582,6 +582,11 @@ static s32 wilc_parse_assoc_resp_info(u8 u16 ies_len; struct wilc_assoc_resp *res = (struct wilc_assoc_resp *)buffer; + if (buffer_len < sizeof(*res)) { + ret_conn_info->status = WLAN_STATUS_UNSPECIFIED_FAILURE; + return -EINVAL; + } + ret_conn_info->status = le16_to_cpu(res->status_code); if (ret_conn_info->status == WLAN_STATUS_SUCCESS) { ies = &buffer[sizeof(*res)];