From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 087F943BDB5; Mon, 17 Aug 2026 13:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974515; cv=none; b=jI1ndlSL9x0lA5OutN4f4+TYRHBzMpJMx0cuR0QrMA3ZH5UpJxWjQFdDR9EQw7ny2Y6kI9Cjjd/qV3lGeTKN2aQXSwvQgsC3z+fxzQZVLEOsOiGVAo33/MSGyK6Uf0QHXvDAEMCsj/Fto2P3HRcX5QiIwWIrII2Drf+c6zWlOTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786974515; c=relaxed/simple; bh=9XoWULJ5V2iO4qsw8xqlVIPyi6zDqG/8CCIwLmlBW4M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IF3h3pcYWBF1KtAOGCMFdrConIS6OCnfOXLcaRbevnVWMHuQik8J17DQxNcrEpRuzQdHIhic5Z7xU54nwTP3zc3xItg2EApe+7nU1kL3UjV0Q9rtJeyQCxj+THRQbeurwRkIQNigdR3w58/kRMPdsU64VEo7XxGkBT7PjS7pG2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J4+skgYa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J4+skgYa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0E381F00A3A; Mon, 17 Aug 2026 13:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786974509; bh=KMx52U8c+d56Q5/0+LNyj2cgeg1SFVgckauf4yyBFr8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=J4+skgYa70IfbCSC9iBazHKajG85xnwC0YuWu8ZxTwJSNpPBC5XK0g7+DHQ7Z6BG/ AAwtriwkefO1gz/T4dFN5D1Tw6AM8yb0CZP4Wx1NXvtxY7U4mjhZQS/jjImsTkgMm6 CTgZ67QNc6gPFcK4m9zWnFt8nP75KimFz1irmSao= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Breno Leitao , "Borislav Petkov (AMD)" Subject: [PATCH 7.1 230/271] x86/mce: Set up the polling timer before CMCI discovery Date: Mon, 17 Aug 2026 15:32:35 +0200 Message-ID: <20260817132546.230106936@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132536.752504388@linuxfoundation.org> References: <20260817132536.752504388@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Breno Leitao commit a213dfaa2596c1c0dc4dae91c14fbfa499c03223 upstream. I hit the following on one of my machines: mce: CPU0 BANK15 CMCI inherited storm ------------[ cut here ]------------ ODEBUG: assert_init not available (active state 0) object: (____ptrval____) object type: timer_list hint: 0x0 WARNING: lib/debugobjects.c:632 at debug_object_assert_init+0x178/0x230, CPU#0: swapper/0/0 CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 7.2.0-rc5 #3 PREEMPTLAZY RIP: 0010:debug_object_assert_init+0x18f/0x230 Call Trace: __mod_timer mce_timer_kick cmci_discover intel_init_cmci mce_intel_feature_init mcheck_cpu_init identify_cpu identify_boot_cpu arch_cpu_finalize_init start_kernel A second splat follows right after, from timer_setup() finding that same timer already queued: ODEBUG: init active (active state 0) object: (____ptrval____) object type: timer_list hint: stub_timer+0x0/0x10 This is happening because CMCI storm detection is trying to modify the timer before latter was properly set up. Set up the timer first. __mcheck_cpu_setup_timer() only calls timer_setup(), and depends on neither the generic nor the vendor init. [ bp: Massage commit message. ] Fixes: 1f68ce2a0272 ("x86/mce: Handle Intel threshold interrupt storms") Signed-off-by: Breno Leitao Signed-off-by: Borislav Petkov (AMD) Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260803-mce_timer_init-v1-1-9539db424330@debian.org Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/cpu/mce/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -2269,10 +2269,10 @@ void mcheck_cpu_init(struct cpuinfo_x86 mca_cfg.initialized = 1; + __mcheck_cpu_setup_timer(); __mcheck_cpu_init_generic(); __mcheck_cpu_init_vendor(c); __mcheck_cpu_init_prepare_banks(); - __mcheck_cpu_setup_timer(); cr4_set_bits(X86_CR4_MCE); }