From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA267427FB2; Mon, 17 Aug 2026 14:17:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976267; cv=none; b=lT7lh5Kw2+1Kn1bBfL3LpRyZPe+M/5Nyj1C49AziwSDi84EHP67uQypXNOx2KqNRatzTJk7Ld00G1C4WuaB84434MZPXsghaL3xxp/jdefbt1EVgkjQ/LYutTutcBTdfvs1uG1T3ZwZXd892d1qC97VUpaeTg1t0UScne7IgfVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976267; c=relaxed/simple; bh=z+NyhVmOvc3WqyaVdLzT5Ruiu+tXUVHcu8DoFf73v5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jqUNu1G8bTS6VJCEC6DudJVKcEse+rgt/IIOgMbRU8iqMAMHweQWya+Zm0oJrpaAmghBoVwf5IzgobSd1jJiIyfyIXpQFRJw5r8sqGI5pZenxt/s/GQWqM7fzW7GCU4RDX2K3tJdSgujJXt7FTxsGiqKe9hZ0hWQonDdwqoWJOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=U6b+Sz/s; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="U6b+Sz/s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E5461F00A3A; Mon, 17 Aug 2026 14:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786976266; bh=9MrA2JNvgwL7lvOavtqiy1VLHMxIbxEMDGEzpX5DZ2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=U6b+Sz/s9MlPkweTMRnubBgGxnDukyO3MLeOgupsMPV4Oc5Ti6muWuBN0L/5aTVqK Thj3MlvNDDcO1N9xnmGrknVVA1lqDOhpaWDY3orfgE8P2fJ6Q0j9PwS5taKpMkHU54 TkCEU64r5fdUcyh3/tbaejie7X2tFhqeqUdij8Q0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuho Choi , Avi Fishman , Andrew Jeffery , Sasha Levin Subject: [PATCH 5.10 313/389] ARM: npcm: Fix OF node refcount leaks in SMP setup Date: Mon, 17 Aug 2026 15:32:32 +0200 Message-ID: <20260817132551.199173349@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuho Choi [ Upstream commit 8eb052f48331474c2789d07b7f11165c323bd2f9 ] npcm7xx_smp_boot_secondary() and npcm7xx_smp_prepare_cpus() look up the GCR and SCU nodes with of_find_compatible_node(). The returned nodes are used for of_iomap(), but the node references are never released. of_iomap() does not consume the device node reference, and iounmap() only releases the MMIO mapping. Drop each node reference after the corresponding mapping attempt. Fixes: 7bffa14c9aed ("arm: npcm: add basic support for Nuvoton BMCs") Signed-off-by: Yuho Choi Reviewed-by: Avi Fishman Signed-off-by: Andrew Jeffery Signed-off-by: Sasha Levin --- arch/arm/mach-npcm/platsmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-npcm/platsmp.c b/arch/arm/mach-npcm/platsmp.c index 21633c70fe7fe..fe63edc9886df 100644 --- a/arch/arm/mach-npcm/platsmp.c +++ b/arch/arm/mach-npcm/platsmp.c @@ -35,6 +35,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu, goto out; } gcr_base = of_iomap(gcr_np, 0); + of_node_put(gcr_np); if (!gcr_base) { pr_err("could not iomap gcr"); ret = -ENOMEM; @@ -63,6 +64,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int max_cpus) return; } scu_base = of_iomap(scu_np, 0); + of_node_put(scu_np); if (!scu_base) { pr_err("could not iomap scu"); return; -- 2.53.0