From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6AA175A6B; Mon, 17 Aug 2026 14:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977654; cv=none; b=gVHj4HcMuzNzPPX2Hk/f/MoE0tJwfSx0TBxqYfQcqQaf2Dg3vU/8PaKGMZ4IG2rIlzp1ruc2b/+hNDtec5B/L/FxZ02XWIgLEndAWl/WrppYDVntwIdkXXTkJgO0OsahaT33OrmYpL3cA0JJEYajNvTGbd+ISDxkHadbrF7F0qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977654; c=relaxed/simple; bh=riSwfmJlyxPF/QkUSSyyug88qt3vTvI5IRFKyAkNuJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZsC16m0lYUGqJhfdR2/TB1+5kKoE0O0xgrdDLABTFXeqxeJLFwmCOdDiW1rlltuN1hSIdtETbPQ/VEDzwSZ57qaFowIouHBvN5ChI6wat3pr2xDxjGDAcIZWn4wLDuQpYzy0PDvq+qLIXezHvnojrJxGYMmRF2H98kTuZu0JPvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WkLCd8ku; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WkLCd8ku" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8EAA1F000E9; Mon, 17 Aug 2026 14:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786977653; bh=X1rnCub5ZexALdCNmt2ug8unu3ByXV1evg8S7Ub3rCo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WkLCd8kun7kZFQBtFV9jfkVr6Uqy6ZfWz+avCgYp4sZlQAxOk/8FcY2/16wrZ2KmK mzrUGlLxXrZ5qmccbuHyaT4B8nomladTsU/EDgSCQ+9gOFz9kTYyOmQtNqQg70Vo08 EHTN1u7VL+eAInjpzePi5CAdRJz+VNFaMsAtCqDI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnd Bergmann , stable , Pawel Laszczak Subject: [PATCH 5.15 404/456] usb: cdnsp: fix incorrect endian conversions for APB timeout register Date: Mon, 17 Aug 2026 15:33:14 +0200 Message-ID: <20260817132555.110406044@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132539.792407575@linuxfoundation.org> References: <20260817132539.792407575@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pawel Laszczak commit 50b303f3d0f7de543ee90d50879970783d06da33 upstream. readl() already returns a CPU-endian value. Passing its return value to le32_to_cpu() is therefore redundant and causes an incorrect double byte swap on big-endian systems. Similarly, writel() expects a CPU-endian value, so passing the result of cpu_to_le32() is incorrect. Remove the unnecessary conversions and operate on the MMIO register value as a CPU-endian u32. Fixes: 241e2ce88e5a ("usb: cdnsp: Fix issue with resuming from L1") Suggested-by: Arnd Bergmann Cc: stable Signed-off-by: Pawel Laszczak Acked-by: Arnd Bergmann Link: https://patch.msgid.link/20260720-endian-fix-v1-v1-1-b5681fa1ea9f@cadence.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/cdns3/cdnsp-gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/cdns3/cdnsp-gadget.c +++ b/drivers/usb/cdns3/cdnsp-gadget.c @@ -154,9 +154,9 @@ static void cdnsp_set_apb_timeout_value( offset = cdnsp_find_next_ext_cap(base, offset, D_XEC_PRE_REGS_CAP); reg = base + offset + REG_CHICKEN_BITS_3_OFFSET; - val = le32_to_cpu(readl(reg)); + val = readl(reg); val = CHICKEN_APB_TIMEOUT_SET(val, cdns->override_apb_timeout); - writel(cpu_to_le32(val), reg); + writel(val, reg); } static void cdnsp_set_chicken_bits_2(struct cdnsp_device *pdev, u32 bit)