From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F10E2EC0B0 for ; Mon, 17 Aug 2026 14:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975394; cv=none; b=rZTooSiFwQ4ZRI6aBFXWIfrmxfX9wDNKMZi2uN0xuhg54BeVVLWYo53sjzFJGlIZfnr2pLARGt0fbgQfEzLgThPo2G+Xkxz4+6gcXEyybR9+CmAqPyn+pp5YX7kVp4bR4K4jCwvHPtaB1dVy5hv0bDBXFNBNLUFZIeNa6dHKRMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975394; c=relaxed/simple; bh=vGyNnOMQtnm/E+3qyU0f6uHZTlNsAgRe1tDUPXSD7us=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UE8pVDNAXb7OPRy1t8Khrr91YpWDyC0nizhYcZRAEqhtFcChnNutrbg+M7K4FmqwGJe0lFhB6uPJ6H7ga+Q1er+hPF1yKPvx9yTX6/Cl/oMJiENFaX5cCTDOLFUb0UJt+pqRLj9Hftv3qfpRvCvqxl1erWo/AKxuFc0QVA9IgZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YzkZvoOk; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YzkZvoOk" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso37051775ad.2 for ; Mon, 17 Aug 2026 07:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786975393; x=1787580193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=izcVO6R3v4+neqjC7EnHrbwsHX05E2W9qHGBbkC6pXk=; b=YzkZvoOk7eTc9ZgrarnTe16OFt03ra7o9bP2OBdw6bF2fYrGyHzpk1IfmssbrUmHl/ emN0xhfjqzgSeCG1NzLK9nalISlAp/6VWEGGE3ueVaKsvbAqzwi6RJ3dfblwzDSE7AOU MWeqxajihRuBID12Kerk2m3Y2ZTzdVeDdDcY+x9lF8NQlXD+4LJ/nRi5Fabk5/EwQ1ev wTXUkypc+5UQjMLHCaon8Fo4h4H/Gm1pUyyECkiUpYndyu6B3L4iyyVa4zHIycapD0n4 KgwuV+80Y2R2+x2nRRN/YdLMD3kEQok29yGelRT6PUEj3LxdTItYad9y8PjZcaaCV+TO gRfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786975393; x=1787580193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=izcVO6R3v4+neqjC7EnHrbwsHX05E2W9qHGBbkC6pXk=; b=B6JueiZIeieXRABgofWYwZTBnpisNF4lc4kESlPeC4RFWW4A/0DlgVntVGc8tRdcuJ jTrc8CKZGi7ydwL1b6b28metDnwchyp4Y0tqfw1w8+j/7tsTq1oqypcIRWXnDsnvzckW JT30jkHA76+LQlcfoeItcFWDuMOCKc+GPlzTW7db4/sV1LHaqhRnhJ2Tpxzdplne6wv8 11A/2tLHSDyNy9Wi+I+KbKLibGhySweT8wynGWXVQnGrwIlB2s2zZEEB9zpuMHmErZRC XwOKOHG/SE4IAfc5n4A4OXsVdrh+HL+8u0QJ1nuU5/ndWKwjk1XjqgnuXqA0bSitpfyt 65+g== X-Forwarded-Encrypted: i=1; AHgh+RpfDF3aWbP0ookHQCOa6KwRfh91Krw434b/QfdJgS+VeAZdVj2NH9QQ8gQ08jMlqoy5dC9R8xqzW9ki+M8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7Wp8h1hCFeByj34FoH4tUIN4V4E9qxG9Rid9loyhG2P2Gr/DX nWnhV+Sp8xu3lsV1+5Bsfpc00Ac4ZSkgKxctyAYp+4UjoEWT/pF+kK8= X-Gm-Gg: AR+sD12YKI8UbzIp0bqxzaeCnyytZHCQRR1bTn3uH3N/6jN+DSKbeHlW2hoWxu8D7b5 yOTm2EebpC2nur5SkF0q7Yg52ojFP50ZwCizXQtPWn7ICT6oYhK36DCwn2PeNZwyhmxvDSg4hRR TbOQexZot9gZWFD5qJ7y9nT3ytTAWsnAgXwRg7iPuF0SajMHQpD65YpjF3rkNsN4bA/dl3epqG+ vu8ZanI0caSFXRVx9+ZuKcfihCHVI5C70g5pb85BsdZZtUTtVlw71b+G9IB50MJvikohmJ2ZjKS i8DEPvawLvlgDXvnr0n95Pl2bnmpmQ1Ep9yFdeZG7FPZXQlkmjEnBExU1/Snk6EA4OdIyfTiobV calJhTjKyYIAn9dFWqEThkl2xtj9IqTFGUehQxhsl4WFirbciXXbOLURBVY6v3lrn4XZXXyUKis wIqXU6b1/UJEXkKPv2oBcN465BaMGAnbfAgdTZw6ZonVXZ+7RLuToKsomYJc1ToBEKU3ZledhOk RyJUiPKsTl1kyCuGqkhTvSno8CqMickJzHAL/cZ3WFPP5lKEvXMI/IqeVozuzqyTFbh7Zxrt+M+ E1Ya+4Bq X-Received: by 2002:a17:902:f68a:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2d3b0da664amr251108225ad.18.1786975392648; Mon, 17 Aug 2026 07:03:12 -0700 (PDT) Received: from codespaces-2db70c.m2fxbej512jepnsor2itp05j3d.ix.internal.cloudapp.net ([207.46.224.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5bb4dfe6dsm6364195ad.18.2026.08.17.07.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 07:03:12 -0700 (PDT) From: Triet Hoang X-Google-Original-From: Triet Hoang <89897892+HMTCT@users.noreply.github.com> To: tomeu@tomeuvizoso.net Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, royalnet026@gmail.com, Markus.Elfring@web.de, Triet Hoang Subject: [PATCH v4 2/2] drm/rocket: Keep scheduler allocation in rocket_file_priv Date: Mon, 17 Aug 2026 14:01:10 +0000 Message-ID: <20260817140110.148873-2-89897892+HMTCT@users.noreply.github.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260817140110.148873-1-89897892+HMTCT@users.noreply.github.com> References: <20260817093009.22359-1-royalnet026@gmail.com> <20260817140110.148873-1-89897892+HMTCT@users.noreply.github.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Triet Hoang Keep the scheduler allocation in rocket_file_priv and free it unconditionally in rocket_job_close(). Suggested-by: Igor Paunovic Link: https://lore.kernel.org/all/20260817093009.22359-1-royalnet026@gmail.com/#t Signed-off-by: Triet Hoang --- drivers/accel/rocket/rocket_drv.h | 1 + drivers/accel/rocket/rocket_job.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/accel/rocket/rocket_drv.h b/drivers/accel/rocket/rocket_drv.h index 2c673bb99ccc..9421e48ec5d8 100644 --- a/drivers/accel/rocket/rocket_drv.h +++ b/drivers/accel/rocket/rocket_drv.h @@ -23,6 +23,7 @@ struct rocket_file_priv { struct drm_mm mm; struct mutex mm_lock; + struct drm_gpu_scheduler **scheds; struct drm_sched_entity sched_entity; }; diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index adcc792541ec..ff1d9e802024 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -514,8 +514,11 @@ int rocket_job_open(struct rocket_file_priv *rocket_priv) DRM_SCHED_PRIORITY_NORMAL, scheds, rdev->num_cores, NULL); + if (WARN_ON(ret)) kfree(scheds); + else + rocket_priv->scheds = scheds; return ret; } @@ -525,6 +528,7 @@ void rocket_job_close(struct rocket_file_priv *rocket_priv) struct drm_sched_entity *entity = &rocket_priv->sched_entity; kfree(entity->sched_list); + kfree(rocket_priv->scheds); drm_sched_entity_destroy(entity); } -- 2.53.0