Re: [PATCH 1/6] selftests/bpf: libarena: Normalize SPDX headers across files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The commit message claims to normalize libarena to a uniform 'dual GPLv2/BSD-2-Clause license', but the patch actually applies a mix of LGPL-2.1 and GPL-2.0 licenses.
- [Medium] Relicensing code authored by others requires their explicit Acked-by or Signed-off-by, not just a CC.
- [Low] SPDX License Identifiers in C header files are improperly formatted using `//` comments instead of `/* ... */`.
--

--- Patch [1]: [PATCH 1/6] selftests/bpf: libarena: Normalize SPDX headers across files ---
commit 31e67a726c2a90149ef6d815e971306cd776d717
Author: Emil Tsalapatis <emil@etsalapatis.com>

selftests/bpf: libarena: Normalize SPDX headers across files

This commit normalizes SPDX headers in libarena by adding missing headers 
and updating existing ones. It states the intention to apply a uniform 
dual GPLv2/BSD-2-Clause license across the components.

> There are currently three files missing headers and two of them
> (both originally authored by Kartikeya, CC'ed below) that are
> GPLv2 only. This patch ensures all files in libarena have a
> dual GPLv2/BSD-2-Clause license in the example of other non-
> kernel BPF codebases, e.g., libbpf.

[Severity: Medium]
Is a Cc sufficient for changing the license of existing code? Relicensing 
code originally authored by others typically requires their explicit 
Acked-by or Signed-off-by tags to document their consent, rather than 
just a Cc.

> diff --git a/tools/testing/selftests/bpf/libarena/include/bpf_may_goto.h b/tools/testing/selftests/bpf/libarena/include/bpf_may_goto.h
> --- a/tools/testing/selftests/bpf/libarena/include/bpf_may_goto.h
> +++ b/tools/testing/selftests/bpf/libarena/include/bpf_may_goto.h
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause
>  #pragma once

[Severity: Medium]
The commit message states the patch ensures all files have a dual 
GPLv2/BSD-2-Clause license, but this adds an LGPL-2.1 tag. Was this 
intended to be GPL-2.0 to match the other updated headers, or should the 
commit message be updated to reflect the mix of licenses?

[Severity: Low]
Also, according to the kernel's documentation, C header files should use 
the C-style block comment format /* SPDX-License-Identifier: ... */ 
rather than C++ style // comments.

> diff --git a/tools/testing/selftests/bpf/libarena/include/libarena/bitmap.h b/tools/testing/selftests/bpf/libarena/include/libarena/bitmap.h
> --- a/tools/testing/selftests/bpf/libarena/include/libarena/bitmap.h
> +++ b/tools/testing/selftests/bpf/libarena/include/libarena/bitmap.h
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause
>  #pragma once

[Severity: Low]
This header file also uses the // comment style instead of the /* ... */ 
block comment format expected for C headers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260817191616.11071-1-emil@etsalapatis.com?part=1