All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: longlong yan <yanlonglong@kylinos.cn>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: f_fs-aio-simple: add NULL checks for malloc calls
Date: Mon, 17 Aug 2026 08:32:57 +0200	[thread overview]
Message-ID: <2026081736-rendering-excess-0bee@gregkh> (raw)
In-Reply-To: <20260817062756.781-1-yanlonglong@kylinos.cn>

On Mon, Aug 17, 2026 at 02:27:56PM +0800, longlong yan wrote:
> Add NULL checks for the return values of malloc() in the aio_simple
> FFS example application. If any of the four malloc calls (buf_in,
> buf_out, iocb_in, iocb_out) fails, the subsequent code would
> dereference NULL pointers in the main loop.
> 
> Since free(NULL) is safe, the error path frees all four buffers
> unconditionally, then cleans up the remaining resources (io context,
> endpoint file descriptors) consistent with the existing cleanup at
> the end of the function.
> 
> Signed-off-by: longlong yan <yanlonglong@kylinos.cn>
> ---
>  .../ffs-aio-example/simple/device_app/aio_simple.c  | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c
> index 96616eb4600b..07ca1f136ad7 100644
> --- a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c
> +++ b/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c
> @@ -294,6 +294,19 @@ int main(int argc, char *argv[])
>  	iocb_in = malloc(sizeof(*iocb_in));
>  	iocb_out = malloc(sizeof(*iocb_out));
>  
> +	if (!buf_in || !buf_out || !iocb_in || !iocb_out) {
> +		perror("malloc");
> +		free(buf_in);
> +		free(buf_out);
> +		free(iocb_in);
> +		free(iocb_out);
> +		io_destroy(ctx);
> +		for (i = 0; i < 2; ++i)
> +			close(ep[i]);
> +		close(ep0);
> +		return 1;
> +	}

It's userspace, why not just return an error and let the kernel clean up
the memory automatically?

Or better yet, just have a goto to jump to the end of the function where
all of this code already lives?

How did you find this problem?  How was it tested?

thanks,

greg k-h

      reply	other threads:[~2026-08-17  6:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17  6:27 [PATCH] usb: f_fs-aio-simple: add NULL checks for malloc calls longlong yan
2026-08-17  6:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026081736-rendering-excess-0bee@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=yanlonglong@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.