From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF1B3C5DF80 for ; Tue, 18 Aug 2026 11:19:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwHqK-0003Ec-45; Tue, 18 Aug 2026 07:18:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwHqI-0003AQ-GW for qemu-devel@nongnu.org; Tue, 18 Aug 2026 07:18:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwHqG-000661-UN for qemu-devel@nongnu.org; Tue, 18 Aug 2026 07:18:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787051932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BsmdlaFnrsY3I+1UFAW3E5SehDcZ9lldQlqYb3G66HE=; b=S2Wn0O1/7RIstf7Qzi3rCZM6sYNkCorNH4frJ/duhJqgOnOl/w9fwPC2OPqaPZ/x9EXg47 mnvG1Uni5WfaBEj4QcXHL4fmK7a/l+z3ITYN0L5AcjTU8bI8MNb3NJeqNCZ2Zc31qhohBI aEj2tqZgQ6Hh97aUnobkEDXxYnlzocI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-g4lL4Jx5PtWwzWiWBlHIBg-1; Tue, 18 Aug 2026 07:18:50 -0400 X-MC-Unique: g4lL4Jx5PtWwzWiWBlHIBg-1 X-Mimecast-MFC-AGG-ID: g4lL4Jx5PtWwzWiWBlHIBg_1787051929 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 920E61955F3D; Tue, 18 Aug 2026 11:18:49 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 98A44180049F; Tue, 18 Aug 2026 11:18:48 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Tue, 18 Aug 2026 15:10:51 +0400 Subject: [PATCH v3 24/74] sev: convert OnOffAuto legacy-vm-type property to QAPI-aware registration MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260818-qom-qapi-v3-24-24b8bbbe3d86@redhat.com> References: <20260818-qom-qapi-v3-0-24b8bbbe3d86@redhat.com> In-Reply-To: <20260818-qom-qapi-v3-0-24b8bbbe3d86@redhat.com> To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Michael Roth , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Marcelo Tosatti , Zhao Liu , kvm@vger.kernel.org X-Developer-Signature: v=1; a=openpgp-sha256; l=2878; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nkdSCroCL4rc/fXglavopKUEFdlDWMM9nOCJlhTw/EI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqhD24pvx3ql+ZkehN6RSLvFPXUC4lRQL0xUxPC Wn6w7rAZMaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaoQ9uAAKCRDa6OEJdZac 5Uu3EACZbJeifRZ/wBI4hxZp9Pmq1hD/nshXm+OLnCOjvOmtwgiluUSPXlR7CwzA3qIGiYC7kuE GXEZ+9kJ8wZJ+uz53SoLyYRpXz2nYo6t7yux8jSF4W/YP8J1gisT2qhd2OAOpnwldg89SAv+48k ecUim5oFdTsK+PeVHOoWelPilMT8KOuStGcnUYvSVlyK674pekPbWouyDg/Vw9XQRk0+skjaC4c lkZKLX259HbG1EQ+c0o3bRmbEC6Cu4M7Lrs1LHVqH6MqjOSkMPXhbhd5bKiKr+aV1QdjUV2nZ0f B4JdfqVtEMFguc37IzrFTHrzvHp5TwM+aAXcrqS3pauB5Tp4F2zXz+DQxMvs5EagKwqZwYZTPkp E67vg0vakMYvcRZIp9UOUAEJyYm2mrGw+ymRFwGApcqF//VrD7ITpZ7bmiD5U23mRA0gIMHWL7d whkMdZZWYz+eYsEERiGTpS4MMt0QQCvEiiKCICwOUjWgV0+D43ZJvgH+8tKmoAA7N1ur+2QWmMK HdE3NVteRTqgJ7Y4hSaoD+A/PKDVZFMQPue/ajwcn1D/vpHAkcfloD7XRkLL8qUYONKuuzF2ZVe i4YhNibDRiDrTGxq0Ihv1DvzpO1vI5bQaK0LddS+pSOlcXgIPGXF0QJQe2kz1zTjjvwRItYoRLs ytHCUr7G4yLNzIQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.343, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Convert the legacy-vm-type OnOffAuto property from manual visitor-based callbacks to property_add_qapi_enum(). Signed-off-by: Marc-André Lureau --- target/i386/sev.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index d7dcefc8ecf5..335a504af4db 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -20,6 +20,7 @@ #include #include "qapi/error.h" +#include "qapi/qapi-type-infos-common.h" #include "qom/object_interfaces.h" #include "qemu/base64.h" #include "qemu/module.h" @@ -2880,23 +2881,16 @@ sev_guest_set_session_file(Object *obj, const char *value, Error **errp) SEV_GUEST(obj)->session_file = g_strdup(value); } -static void sev_guest_get_legacy_vm_type(Object *obj, Visitor *v, - const char *name, void *opaque, - Error **errp) +static int sev_guest_get_legacy_vm_type(Object *obj, Error **errp) { SevGuestState *sev_guest = SEV_GUEST(obj); - OnOffAuto legacy_vm_type = sev_guest->legacy_vm_type; - - visit_type_OnOffAuto(v, name, &legacy_vm_type, errp); + return sev_guest->legacy_vm_type; } -static void sev_guest_set_legacy_vm_type(Object *obj, Visitor *v, - const char *name, void *opaque, - Error **errp) +static void sev_guest_set_legacy_vm_type(Object *obj, int value, Error **errp) { SevGuestState *sev_guest = SEV_GUEST(obj); - - visit_type_OnOffAuto(v, name, &sev_guest->legacy_vm_type, errp); + sev_guest->legacy_vm_type = value; } static void @@ -2922,11 +2916,14 @@ sev_guest_class_init(ObjectClass *oc, const void *data) sev_guest_set_session_file); object_class_property_set_description(oc, "session-file", "guest owners session parameters (encoded with base64)"); - object_class_property_add(oc, "legacy-vm-type", "OnOffAuto", - sev_guest_get_legacy_vm_type, - sev_guest_set_legacy_vm_type, NULL, NULL); - object_class_property_set_description(oc, "legacy-vm-type", - "use legacy VM type to maintain measurement compatibility with older QEMU or kernel versions."); + object_class_property_add_qapi_enum(oc, QAPI_ENUM_PROP( + .name = "legacy-vm-type", + .description = "use legacy VM type to maintain measurement " + "compatibility with older QEMU or kernel versions.", + .qapi_type = &OnOffAuto_type_info, + .get = sev_guest_get_legacy_vm_type, + .set = sev_guest_set_legacy_vm_type, + )); } static void -- 2.55.0.543.g5ebe2ebe4ea8