From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 630DEC5DF7D for ; Tue, 18 Aug 2026 11:25:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwHvZ-0004DP-KD; Tue, 18 Aug 2026 07:24:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwHvY-0004Cv-Eq for qemu-devel@nongnu.org; Tue, 18 Aug 2026 07:24:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwHvW-0007GP-Ot for qemu-devel@nongnu.org; Tue, 18 Aug 2026 07:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787052258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjQUeWzB+URGNhy51pTY8kngaMPVjWJKxA5gkx975Fc=; b=Jxf76+JGQo4Qb0+8HKz424+nJyc67T2jCFBaRDVxBj5ORGointcPr0+wSmWz4ljtKevYzh stW7u2veuU1AOkZgqYZGeYFNVlsmEbjbLUkj7g/0EFsy7tVaiGjO8cy3bxVsiGhNh/1RVV 4qZ9PB6/z+dKOmdd37rBTcYtZ/PzWl0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-N1daW5HWNVOjkVnoRXQwtw-1; Tue, 18 Aug 2026 07:24:06 -0400 X-MC-Unique: N1daW5HWNVOjkVnoRXQwtw-1 X-Mimecast-MFC-AGG-ID: N1daW5HWNVOjkVnoRXQwtw_1787052245 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 472CB195608B; Tue, 18 Aug 2026 11:24:05 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 37FBE3000239; Tue, 18 Aug 2026 11:23:58 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Tue, 18 Aug 2026 15:11:14 +0400 Subject: [PATCH v3 47/74] accel/hvf: convert OnOffSplit property to QAPI-aware registration MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260818-qom-qapi-v3-47-24b8bbbe3d86@redhat.com> References: <20260818-qom-qapi-v3-0-24b8bbbe3d86@redhat.com> In-Reply-To: <20260818-qom-qapi-v3-0-24b8bbbe3d86@redhat.com> To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Michael Roth , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Roman Bolshakov , Phil Dennis-Jordan X-Developer-Signature: v=1; a=openpgp-sha256; l=2469; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=oWCHQCOKOr/KE6g1VOAN6Z+R3g0iOTOZVDDieDqKREY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqhD27DC8PogTLZ7Zc1KXnwkiMMjdQC1+ZsyfD6 Ywzp0RI37iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaoQ9uwAKCRDa6OEJdZac 5fhRD/9G+E5r5X6fVAD76RpukOc8Mqqd5hfUwJcWdCdlNqYnGZVNy+PuBvNtIBvsadTjtNGhOIL 15aYL2FE1qJwT4VXklCB5jDNuSTuCHj/4l2DyO8bhdhqFFWHew2hASqZicV5kSSWc3YHi0rz+AZ nJUZ0HFz/nGoyItnjq+gwgR5lahIJU7Zhlm7jF4NdoS2BelbPXNaK3PTVClmdATnjrRBjMvHL+1 rywFQRp2qwM/EXW0BDr0DPwNuc1/chJxRdcP1Ka9mGGF/vGEwrGFhb3+GDMB8Q/zbTbOdakyShe q1wH+X9kUBolz/fDB/W9CXUIHwGpVLSSAGA2ORYNemuBXyiRePb/UfK08eyN27Ni70qXj2SXe3U bvNHl4HvIyieyn0SMtvP+WNAvqcv4KQXWy0CNM+JXaObPB0Brn60VzR6VaQQzhQaU6h/stZc6yL GHANJDNNDbsxPe8jqCkh3sGIjwb8lpfweC+OKBAwKf0XL/yBmTiYTS6GYvahL4USzimYP8PHBJM y67SNXPYXfLNVnr76x2r0c+RgIcD76u2dG6jEZ8b8Y2Nmhj0uM8H8AuXBMSAcNTVhns2QUFpCVN uU3UWITPwXruGY/7nl6sIGbJ3dCclIiQ5BLVkE7mwwsg+bpnDFAb1c6SPZg3iqZYCFrYpFp3unR SoPd9idj/Uvf60Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 9 X-Spam_score: 0.9 X-Spam_bar: / X-Spam_report: (0.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.343, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Convert the OnOffSplit property from manual visitor-based callbacks to property_add_qapi_enum(). Signed-off-by: Marc-André Lureau --- accel/hvf/hvf-all.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 8bd9154a50b6..2fd594ad156f 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -11,6 +11,7 @@ #include "qemu/osdep.h" #include "qemu/error-report.h" #include "qapi/error.h" +#include "qapi/qapi-type-infos-common.h" #include "qapi/qapi-visit-common.h" #include "accel/accel-ops.h" #include "exec/cpu-common.h" @@ -230,18 +231,12 @@ static int hvf_accel_init(AccelState *as, MachineState *ms) return hvf_arch_init(); } -static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, - const char *name, void *opaque, +static void hvf_set_kernel_irqchip(Object *obj, int value, Error **errp) { - OnOffSplit mode; - hvf_kernel_irqchip_override = true; - if (!visit_type_OnOffSplit(v, name, &mode, errp)) { - return; - } - switch (mode) { + switch (value) { case ON_OFF_SPLIT_ON: #ifdef HOST_X86_64 /* macOS 12 onwards exposes an HVF virtual APIC. */ @@ -261,11 +256,7 @@ static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, break; default: - /* - * The value was checked in visit_type_OnOffSplit() above. If - * we get here, then something is wrong in QEMU. - */ - abort(); + g_assert_not_reached(); } } @@ -277,11 +268,13 @@ static void hvf_accel_class_init(ObjectClass *oc, const void *data) ac->allowed = &hvf_allowed; hvf_kernel_irqchip_override = false; hvf_kernel_irqchip = false; - object_class_property_add(oc, "kernel-irqchip", "on|off|split", - NULL, hvf_set_kernel_irqchip, - NULL, NULL); - object_class_property_set_description(oc, "kernel-irqchip", - "Configure HVF irqchip"); + + object_class_property_add_qapi_enum(oc, QAPI_ENUM_PROP( + .name = "kernel-irqchip", + .qapi_type = &OnOffSplit_type_info, + .set = hvf_set_kernel_irqchip, + .description = "Configure HVF irqchip", + )); } static const TypeInfo hvf_accel_type = { -- 2.55.0.543.g5ebe2ebe4ea8