Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: add BCM4384

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit adds the `brcm,bcm4384-bt` compatible string to the device tree binding schema without adding it to the driver's OF match table, preventing the driver from probing the device.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: net: bluetooth: add BCM4384 ---
commit c161423542c63c738bdc3a02df26a06ea20b52f5
Author: Kaihsin Chung <kaihsin.chung@synaptics.corp-partner.google.com>

dt-bindings: net: bluetooth: add BCM4384

Add the brcm,bcm4384-bt compatible string to support the Synaptics BCM4384
Bluetooth controller.

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> index 95501e858e6f8..612d21123aaad 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
> @@ -31,6 +31,7 @@ properties:
>            - brcm,bcm43540-bt
>            - brcm,bcm4335a0
>            - brcm,bcm4349-bt
> +          - brcm,bcm4384-bt

[Severity: Medium]
Will the driver fail to probe the device using this compatible string?

The commit message mentions adding support for the Synaptics BCM4384, but this
new compatible string is not added to the of_device_id match table in the
driver itself.

Looking at drivers/bluetooth/hci_bcm.c:

static const struct of_device_id bcm_bluetooth_of_match[] = {
        { .compatible = "brcm,bcm20702a1" },
        ...
};

Without an entry in bcm_bluetooth_of_match, the hci_bcm driver will not bind
to the device at boot. Should the driver match table be updated alongside
the binding to ensure the hardware is actually supported?

>            - cypress,cyw4373a0-bt
>            - infineon,cyw55572-bt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818014948.996739-1-kaihsin.chung@synaptics.com?part=1