From: 54weasels <54weasels@gmail.com>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, 54weasels <54weasels@gmail.com>
Subject: [PATCH v4 2/6] target/m68k: Fix fsave/frestore for 68881 FPU
Date: Mon, 17 Aug 2026 19:22:18 -0700 [thread overview]
Message-ID: <20260818022225.31801-3-54weasels@gmail.com> (raw)
In-Reply-To: <20260818022225.31801-1-54weasels@gmail.com>
High level description:
The 68881/68882 FPUs require fsave/frestore instructions to read/write state frames. QEMU only fully implemented this for the 68040. The Sun-3 uses a 68881 FPU, and the boot ROM executes `fsave` to probe FPU presence. This patch adds basic 68881 FPU state frame handling (NULL frame) to accurately simulate an idle FPU state.
Impact on existing functionality:
Fixes FPU detection for 68881/68882 across all M68k boards without affecting 68040 specific state logic.
Context: This patch was originally submitted as part of the monolithic Sun-3 Machine Emulation series (https://patchew.org/QEMU/20260503015756.99176-1-54weasels@gmail.com/) and has been split into atomic components.
---
target/m68k/translate.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 138c89d3e5..bdf619883c 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -5364,11 +5364,19 @@ DISAS_INSN(frestore)
gen_exception(s, s->base.pc_next, EXCP_PRIVILEGE);
return;
}
- if (m68k_feature(s->env, M68K_FEATURE_M68040)) {
+ if (m68k_feature(s->env, M68K_FEATURE_M68040) ||
+ m68k_feature(s->env, M68K_FEATURE_FPU)) {
SRC_EA(env, addr, OS_LONG, 0, NULL);
- /* FIXME: check the state frame */
+ if (m68k_feature(s->env, M68K_FEATURE_M68040)) {
+ /* FIXME: check the state frame */
+ } else {
+ /*
+ * 68881/68882 FRESTORE: read the state frame
+ * (NULL frame is 4 bytes)
+ */
+ }
} else {
- disas_undef(env, s, insn);
+ disas_undef_fpu(env, s, insn);
}
}
@@ -5383,8 +5391,12 @@ DISAS_INSN(fsave)
/* always write IDLE */
TCGv idle = tcg_constant_i32(0x41000000);
DEST_EA(env, insn, OS_LONG, idle, NULL);
+ } else if (m68k_feature(s->env, M68K_FEATURE_FPU)) {
+ /* 68881/68882 FSAVE: always write NULL frame */
+ TCGv null_frame = tcg_constant_i32(0x00000000);
+ DEST_EA(env, insn, OS_LONG, null_frame, NULL);
} else {
- disas_undef(env, s, insn);
+ disas_undef_fpu(env, s, insn);
}
}
#endif
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-08-18 2:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 2:22 [PATCH v4 0/6] Implement missing functionality and hooks in mk68k to support upcoming sun3 impl 54weasels
2026-08-18 2:22 ` [PATCH v4 1/6] target/m68k: Add dummy CAAR register 54weasels
2026-08-18 2:22 ` 54weasels [this message]
2026-08-18 10:52 ` [PATCH v4 2/6] target/m68k: Fix fsave/frestore for 68881 FPU BALATON Zoltan
2026-08-20 4:37 ` Purr Box
2026-08-20 9:55 ` BALATON Zoltan
2026-08-18 2:22 ` [PATCH v4 3/6] target/m68k: Fix NMI pending for Level 7 interrupts 54weasels
2026-08-18 10:56 ` BALATON Zoltan
2026-08-20 7:37 ` Purr Box
2026-08-18 2:22 ` [PATCH v4 4/6] target/m68k: Extract Function Codes during TLB fills 54weasels
2026-08-18 2:22 ` [PATCH v4 5/6] target/m68k: Implement custom MMU intercept hook 54weasels
2026-08-18 2:22 ` [PATCH v4 6/6] target/m68k: Implement Physical Bus Error and Stack 54weasels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818022225.31801-3-54weasels@gmail.com \
--to=54weasels@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.