From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A74F3A6B7F for ; Tue, 18 Aug 2026 03:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787023026; cv=none; b=A/PfGNEHOwGQMi45bOuCpfF7uGR40YBKmgloEJOxydPw1WMJz01XkfWhsnBU8u7ZOWjsGQc9T4rc+dgtsNKDdg4CCsitX2ZcDjkXKgfCWD0khZjMB+elpZ4T0Vwa9J2Pc+2oKPx1etuoMqJP7wW3UQYtQ7/7w3xDBS9KK/Z11Qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787023026; c=relaxed/simple; bh=cJTDTsyyPoqTZH3VUm2LodZZtf1cH++EX4b4mDOU1aI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WRyIP88XGAsANY4mDFhd998qjpdEz/sOueLeyAfeiI3tWCNPgoFAtrHkaGHlqBNd7tVo2Hfkj8d+tlrDzx8qbVbuRjO5pK+iGCfvmKMMBgZkzcHrr6b/E4sPeWczE5mH2KHAqTPBLIeidy42kHSm9xJY6LZDDzMv9IDXosj2a3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S.localdomain (unknown [36.110.52.2]) by APP-03 (Coremail) with SMTP id rQCowABXWzmezoNqVsmzBQ--.13175S2; Tue, 18 Aug 2026 11:16:46 +0800 (CST) From: Haotian Zhang To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] irqchip/ingenic-tcu: free generic chips on error path Date: Tue, 18 Aug 2026 11:02:06 +0800 Message-ID: <20260818030206.4420-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowABXWzmezoNqVsmzBQ--.13175S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw1rGw47Xr47tr4fKrWxWFg_yoW8Gr1DpF 48Z3y3ursrJr17Xr48Cr1UW34Yg34jg3yjg3WSkwnFvFn8Ca1qkFyqvF1xur1UCa1xJan0 yFs7Ja4UCryUAFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyK14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI 7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxV Cjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6x AIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUYzuWDUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwYDA2qDqo+nRAAAsu irq_alloc_domain_generic_chips() stores the allocated generic chip data in domain->gc. On the error path taken when irq_of_parse_and_map() fails, ingenic_tcu_irq_init() calls irq_domain_remove() without first calling irq_domain_remove_generic_chips(). As the domain was created with irq_domain_add_linear(), which does not set IRQ_DOMAIN_FLAG_DESTROY_GC, irq_domain_remove() never frees the generic chips and the allocation leaks. Call irq_domain_remove_generic_chips() before irq_domain_remove() so that the generic chip data is released on the error path. Fixes: 9536eba03ec7 ("irqchip: Add irq-ingenic-tcu driver") Signed-off-by: Haotian Zhang --- drivers/irqchip/irq-ingenic-tcu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-ingenic-tcu.c b/drivers/irqchip/irq-ingenic-tcu.c index 794ecba717c9..637fd90d97aa 100644 --- a/drivers/irqchip/irq-ingenic-tcu.c +++ b/drivers/irqchip/irq-ingenic-tcu.c @@ -171,6 +171,7 @@ static int __init ingenic_tcu_irq_init(struct device_node *np, for (; i > 0; i--) irq_dispose_mapping(tcu->parent_irqs[i - 1]); out_domain_remove: + irq_domain_remove_generic_chips(tcu->domain); irq_domain_remove(tcu->domain); err_free_tcu: kfree(tcu); -- 2.43.0