From: sashiko-bot@kernel.org
To: "Anshuman Khandual" <anshuman.khandual@arm.com>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [RFC V3 3/8] loongarch/mm: Stop using pte_ERROR()
Date: Tue, 18 Aug 2026 04:19:00 +0000 [thread overview]
Message-ID: <20260818041900.B43C61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818040041.1891769-4-anshuman.khandual@arm.com>
> Directly use pr_err() in __set_fixmap() and drop pte_ERROR() which helps in
> eventually dropping pte_ERROR() macro across the tree. In this new printing
> __FILE__ and __LINE__ has been dropped because they are always the same and
> don't really add any value. The new ptval_to_str() helper is being used for
> converting pgtable entry value into a string. The error message itself has
> been cleaned up as well.
>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818040041.1891769-1-anshuman.khandual@arm.com?part=3
next prev parent reply other threads:[~2026-08-18 4:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 4:00 [RFC V3 0/8] mm: Drop pxd_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` [RFC V3 1/8] mm: Make ptrval_to_str() generally available Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:14 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 2/8] mm: Stop using pxd_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:14 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 3/8] loongarch/mm: Stop using pte_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:19 ` sashiko-bot [this message]
2026-08-18 4:00 ` [RFC V3 4/8] parisc/mm: Directly use generic [pmd|pgd]_clear_bad() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:20 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 5/8] sh/mm: Stop using pte_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:16 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 6/8] sh/mm: Stop using [p4d|pud|pmd]_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:18 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 7/8] sh/mm: Stop using pgd_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:17 ` sashiko-bot
2026-08-18 4:00 ` [RFC V3 8/8] mm: Drop pxd_ERROR() Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:00 ` Anshuman Khandual
2026-08-18 4:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818041900.B43C61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.