All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Jason Angelov <jasonangelov@ucla.edu>
Cc: SJ Park <sj@kernel.org>,
	akpm@linux-foundation.org, shu17az@gmail.com,
	jiayuan.chen@shopee.com, damon@lists.linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/damon/core-kunit: test damon_valid_probe_params()
Date: Mon, 17 Aug 2026 21:55:57 -0700	[thread overview]
Message-ID: <20260818045557.97267-1-sj@kernel.org> (raw)
In-Reply-To: <20260818034552.11975-3-jasonangelov@ucla.edu>

On Tue, 18 Aug 2026 03:45:52 +0000 Jason Angelov <jasonangelov@ucla.edu> wrote:

> damon_valid_probe_params() makes damon_commit_ctx() reject probe
> configurations that could overflow a probe_hits counter, a single
> (weight * probe_hits) product, or the sum of those products.
> 
> Add a kunit test covering each rejection at its boundary:
> 
> - samples per aggregation interval: U8_MAX is allowed, one more could
>   overflow a probe_hits counter
> - single weight: the largest whose product fits in unsigned int is
>   allowed, one larger is rejected
> - multiple probes: each product fits, but their sum overflows
> - no weight set: the validation is skipped

Thank you for adding these tests.

> 
> Signed-off-by: Jason Angelov <jasonangelov@ucla.edu>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

  parent reply	other threads:[~2026-08-18  4:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  3:45 [PATCH 0/2] mm/damon: add kunit tests for probe_hits handling and probe params validation Jason Angelov
2026-08-18  3:45 ` [PATCH 1/2] mm/damon/core-kunit: test probe_hits handling at region split and merge Jason Angelov
2026-08-18  3:57   ` sashiko-bot
2026-08-18  4:46     ` SJ Park
2026-08-18  4:50   ` SJ Park
2026-08-18  3:45 ` [PATCH 2/2] mm/damon/core-kunit: test damon_valid_probe_params() Jason Angelov
2026-08-18  3:50   ` sashiko-bot
2026-08-18  4:55   ` SJ Park [this message]
2026-08-18  4:58 ` [PATCH 0/2] mm/damon: add kunit tests for probe_hits handling and probe params validation SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818045557.97267-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=jasonangelov@ucla.edu \
    --cc=jiayuan.chen@shopee.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shu17az@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.