From: sashiko-bot@kernel.org
To: "Balasubramani Vivekanandan" <balasubramani.vivekanandan@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
Date: Tue, 18 Aug 2026 07:53:48 +0000 [thread overview]
Message-ID: <20260818075349.4A1911F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818075454.1508724-2-balasubramani.vivekanandan@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Selecting DRM_RAS in DRM_XE without inheriting its dependency on NET causes Kconfig warnings and potential build failures.
--
--- Patch [1]: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS ---
commit 591f0eb274f545521022c1143984b07f3d4b5395
Author: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
This commit enables DRM RAS support for the Xe driver by adding a select
statement for DRM_RAS in the DRM_XE Kconfig entry.
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 4d7dcaff2b915..6c584f918edf2 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -42,6 +42,7 @@ config DRM_XE
> select DRM_GPUSVM if !UML
> select DRM_GPUVM
> select DRM_SCHED
> + select DRM_RAS
[Severity: Low]
Does this select statement need to inherit the dependencies of DRM_RAS?
DRM_RAS depends on NET. Since DRM_XE selects DRM_RAS without inheriting
this dependency, it can cause Kconfig unmet direct dependency warnings and
potential build failures if the kernel is configured with CONFIG_NET
disabled.
> select MMU_NOTIFIER
> select WANT_DEV_COREDUMP
> select AUXILIARY_BUS
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818075454.1508724-2-balasubramani.vivekanandan@intel.com?part=1
next prev parent reply other threads:[~2026-08-18 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 7:54 [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS Balasubramani Vivekanandan
2026-08-18 7:52 ` ✗ CI.KUnit: failure for " Patchwork
2026-08-18 7:53 ` sashiko-bot [this message]
2026-08-18 7:59 ` [PATCH] " Raag Jadav
2026-08-18 8:18 ` Tauro, Riana
2026-08-18 13:44 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818075349.4A1911F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=balasubramani.vivekanandan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.