From: Jakub Kicinski <kuba@kernel.org>
To: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
Cc: Selvamani Rajagopal via B4 Relay
<devnull+Selvamani.Rajagopal.onsemi.com@kernel.org>,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Piergiorgio Beruto <Pier.Beruto@onsemi.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error
Date: Tue, 18 Aug 2026 09:33:18 -0700 [thread overview]
Message-ID: <20260818093318.68a6e099@kernel.org> (raw)
In-Reply-To: <DM5PR02MB33692A7DA56968540A3F950383A62@DM5PR02MB3369.namprd02.prod.outlook.com>
On Tue, 18 Aug 2026 16:23:58 +0000 Selvamani Rajagopal wrote:
> > Also the "vendor code may inadvertently enable the queue"
> > is some vague indication of a race? I have no idea what "vendor code"
> > means here, this "library" has one user. If there is a race please fix
> > it. If there's not - please don't add confusing comments.
>
> It is not a race. If vendor's code (or even from command line) marks
> the interface "down" followed by "up", queue may be re-enabled.
Due to a link event? That's a run of the mill situation in drivers
and has to be handled by correctly ordering the events.
I think you shut down the IRQ first, so that's good, not sure if there's
anything else to worry about
> This use case was raised by AI review during the previous submission,
> which is a valid question. So I thought I should capture this in the
> comment.
The comment is confusing.
next prev parent reply other threads:[~2026-08-18 16:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 3:00 [PATCH net v6 0/4] Fix to possible skb leak due to race condtion in tx path Selvamani Rajagopal via B4 Relay
2026-08-13 3:00 ` Selvamani Rajagopal
2026-08-13 3:00 ` [PATCH net v6 1/4] net: ethernet: oa_tc6: Protect skb pointer used by two different kernel instances Selvamani Rajagopal via B4 Relay
2026-08-13 3:00 ` Selvamani Rajagopal
2026-08-13 15:53 ` Selvamani Rajagopal
2026-08-13 18:51 ` Andrew Lunn
2026-08-13 21:16 ` Selvamani Rajagopal
2026-08-14 5:20 ` Selvamani Rajagopal
2026-08-14 17:36 ` Jakub Kicinski
2026-08-13 3:00 ` [PATCH net v6 2/4] net: ethernet: oa_tc6: Improve the error recovery Selvamani Rajagopal via B4 Relay
2026-08-13 3:00 ` Selvamani Rajagopal
2026-08-13 3:00 ` [PATCH net v6 3/4] net: ethernet: oa_tc6: Disable tx queues on fatal error Selvamani Rajagopal via B4 Relay
2026-08-13 3:00 ` Selvamani Rajagopal
2026-08-18 16:06 ` Jakub Kicinski
2026-08-18 16:23 ` Selvamani Rajagopal
2026-08-18 16:33 ` Jakub Kicinski [this message]
2026-08-18 16:50 ` Selvamani Rajagopal
2026-08-13 3:00 ` [PATCH net v6 4/4] net: ethernet: oa_tc6: Fix for the wrong data type Selvamani Rajagopal via B4 Relay
2026-08-13 3:00 ` Selvamani Rajagopal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818093318.68a6e099@kernel.org \
--to=kuba@kernel.org \
--cc=Pier.Beruto@onsemi.com \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devnull+Selvamani.Rajagopal.onsemi.com@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.