From: Jakub Kicinski <kuba@kernel.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/7] netconsole: validate a target's IP address configuration
Date: Tue, 18 Aug 2026 09:51:03 -0700 [thread overview]
Message-ID: <20260818095103.7a7f4c51@kernel.org> (raw)
In-Reply-To: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com>
On Fri, 14 Aug 2026 20:28:51 +0100 Gustavo Luiz Duarte wrote:
> This series adds two validations to the target configuration when the
> user tries to enable it: first whether remote_ip was set, and second
> whether local_ip and remote_ip address families match. Refuse to enable
> the target if any of those validations fail.
>
> These validations are already done for the target passed on the
> command-line, so this aligns dynamic targets with the command-line
> behavior.
>
> The first two patches replace the per-target 'ipv6' flag with a
> per-address 'family' field, which makes it easier to detect these error
> conditions. Patches 3 and 4 implement the actual validations.
>
> Patches 5-7 are follow-ups from previous reviews: move inet_addr from
> netpoll.h into netconsole.c, show an unset address as an empty string
> rather than "0.0.0.0", document local_ip auto-selection.
LGTM, but feels to risky to merge during the merge window.
Since we're changing semantics we should let this sit in linux-next
for at least a week. Please repost in Sept.
BTW please carefully review clashiko feedback:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260814-netcons_ipv6-v3-7-bc0915e8c75f@gmail.com
It marked as preexisting the problem of IP versions diverging but
I think it's relevant (patch 2)?
prev parent reply other threads:[~2026-08-18 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 19:28 [PATCH net-next v3 0/7] netconsole: validate a target's IP address configuration Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 1/7] netconsole: add an address family to struct inet_addr Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 2/7] netconsole: use the address family instead of the ipv6 flag Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 3/7] netconsole: reject enabling a target with no remote IP address Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 4/7] netconsole: reject a target mixing IPv4 and IPv6 addresses Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 5/7] netconsole: show empty string for an unset IP address Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 6/7] netconsole: move struct inet_addr into netconsole.c Gustavo Luiz Duarte
2026-08-14 19:28 ` [PATCH net-next v3 7/7] docs: netconsole: document local_ip auto-selection Gustavo Luiz Duarte
2026-08-17 8:32 ` Breno Leitao
2026-08-18 16:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818095103.7a7f4c51@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.