All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: linux-bluetooth@vger.kernel.org
Subject: [BlueZ] avctp: Fix typo in comment which contradicts the conditional below
Date: Tue, 18 Aug 2026 12:58:21 +0200	[thread overview]
Message-ID: <20260818105827.600893-1-hadess@hadess.net> (raw)

The comment says "If the request set a callback send it directly" but
checks for whether "the request did not set a callback" using
if (!func)
---
 profiles/audio/avctp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
index f20e08c00ac8..336511bf9612 100644
--- a/profiles/audio/avctp.c
+++ b/profiles/audio/avctp.c
@@ -1632,7 +1632,7 @@ static int avctp_send_req(struct avctp *session, uint8_t code,
 	if (control == NULL)
 		return -ENOTCONN;
 
-	/* If the request set a callback send it directly */
+	/* If the request did not set a callback send it directly */
 	if (!func)
 		return avctp_send(session->control, -1, AVCTP_COMMAND,
 				code, subunit, opcode, operands, operand_count);
-- 
2.55.0


             reply	other threads:[~2026-08-18 10:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 10:58 Bastien Nocera [this message]
2026-08-18 12:21 ` [BlueZ] avctp: Fix typo in comment which contradicts the conditional below bluez.test.bot
2026-08-19 19:50 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818105827.600893-1-hadess@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.