From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de, fmancera@suse.de
Subject: [PATCH nf-next 3/4] netfilter: x_tables: do not print specified table
Date: Tue, 18 Aug 2026 14:27:40 +0200 [thread overview]
Message-ID: <20260818122741.1329660-3-pablo@netfilter.org> (raw)
In-Reply-To: <20260818122741.1329660-1-pablo@netfilter.org>
This is defensive, possibly this string has been already been sanitized
but simply print that this match/target extension can only be used for a
given table.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/ipv4/netfilter/ipt_rpfilter.c | 3 +--
net/ipv6/netfilter/ip6t_rpfilter.c | 2 +-
net/netfilter/xt_CONNSECMARK.c | 3 +--
net/netfilter/xt_SECMARK.c | 3 +--
4 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/net/ipv4/netfilter/ipt_rpfilter.c b/net/ipv4/netfilter/ipt_rpfilter.c
index 6d9bf5106868..2c38fd6624aa 100644
--- a/net/ipv4/netfilter/ipt_rpfilter.c
+++ b/net/ipv4/netfilter/ipt_rpfilter.c
@@ -95,8 +95,7 @@ static int rpfilter_check(const struct xt_mtchk_param *par)
if (strcmp(par->table, "mangle") != 0 &&
strcmp(par->table, "raw") != 0) {
- pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table, not \'%s\'\n",
- par->table);
+ pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table\n");
return -EINVAL;
}
diff --git a/net/ipv6/netfilter/ip6t_rpfilter.c b/net/ipv6/netfilter/ip6t_rpfilter.c
index 67c87a88cde4..af8d10d49de8 100644
--- a/net/ipv6/netfilter/ip6t_rpfilter.c
+++ b/net/ipv6/netfilter/ip6t_rpfilter.c
@@ -118,7 +118,7 @@ static int rpfilter_check(const struct xt_mtchk_param *par)
if (strcmp(par->table, "mangle") != 0 &&
strcmp(par->table, "raw") != 0) {
- pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table, not \'%s\'\n",
+ pr_info_ratelimited("only valid in \'raw\' or \'mangle\' table\n",
par->table);
return -EINVAL;
}
diff --git a/net/netfilter/xt_CONNSECMARK.c b/net/netfilter/xt_CONNSECMARK.c
index 1494b3ee30e1..4e4436a9104b 100644
--- a/net/netfilter/xt_CONNSECMARK.c
+++ b/net/netfilter/xt_CONNSECMARK.c
@@ -87,8 +87,7 @@ static int connsecmark_tg_check(const struct xt_tgchk_param *par)
if (strcmp(par->table, "mangle") != 0 &&
strcmp(par->table, "security") != 0) {
- pr_info_ratelimited("only valid in \'mangle\' or \'security\' table, not \'%s\'\n",
- par->table);
+ pr_info_ratelimited("only valid in \'mangle\' or \'security\' table\n");
return -EINVAL;
}
diff --git a/net/netfilter/xt_SECMARK.c b/net/netfilter/xt_SECMARK.c
index 5bc5ea505eb9..38e8e410b4e8 100644
--- a/net/netfilter/xt_SECMARK.c
+++ b/net/netfilter/xt_SECMARK.c
@@ -79,8 +79,7 @@ secmark_tg_check(const char *table, struct xt_secmark_target_info_v1 *info)
if (strcmp(table, "mangle") != 0 &&
strcmp(table, "security") != 0) {
- pr_info_ratelimited("only valid in \'mangle\' or \'security\' table, not \'%s\'\n",
- table);
+ pr_info_ratelimited("only valid in \'mangle\' or \'security\' table\n");
return -EINVAL;
}
--
2.47.3
next prev parent reply other threads:[~2026-08-18 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 12:27 [PATCH nf-next 1/4] netfilter: x_tables: remove pr_debug in matches/targets Pablo Neira Ayuso
2026-08-18 12:27 ` [PATCH nf-next 2/4] netfilter: xt_CT: check for nul-terminated timeout and helper name Pablo Neira Ayuso
2026-08-18 12:27 ` Pablo Neira Ayuso [this message]
2026-08-18 12:55 ` [PATCH nf-next 3/4] netfilter: x_tables: do not print specified table Jan Engelhardt
2026-08-18 14:08 ` Pablo Neira Ayuso
2026-08-18 12:27 ` [PATCH nf-next 4/4] netfilter: xt_cgroup: use pr_info_ratelimited() Pablo Neira Ayuso
2026-08-18 12:47 ` Florian Westphal
2026-08-18 12:54 ` Fernando Fernandez Mancera
2026-08-18 13:10 ` [PATCH nf-next 1/4] netfilter: x_tables: remove pr_debug in matches/targets Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818122741.1329660-3-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=fmancera@suse.de \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.