From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EBF6C5DF7E for ; Tue, 18 Aug 2026 13:13:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C1DA10EB66; Tue, 18 Aug 2026 13:13:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FofqkNJW"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id D411E10E00E; Tue, 18 Aug 2026 13:13:38 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 3D5EB60A73; Tue, 18 Aug 2026 13:13:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 702441F00A3D; Tue, 18 Aug 2026 13:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787058817; bh=8Pz74CHQ647IIVFmbLpghV+tSTi8VywV4inhV1WQvTg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FofqkNJWQcN36rC7dCAbZX7G5hQOs+UYJNfRcF/pEXI521d7pRrSwq8Z+r4KOem0n FpOSMVSz0K5dfYxpegYfLjwEi7TTcZ25btXsgQQFCDEiPY0Lq8wAQ5l7CvEHbi/EiP x6Tn+jVkWpba4/xbUq84rKNyw9nK/1/+ROqDgHKkcS6bFhW+h8bbjqfc7Px9jlyTSB Tp8jFoD5TM1uEdi73kA5diCHpzSHxRUt1tzJks7TLvhHFrq8vOeyvofxoJC8TCyz9/ VkpkFWhwfX+ufDs3d1JSwmky5flDcG9tFNQZok4tJQrU0Rjh8vfUo1BMpsGZoRzILz jB7yrmx2c/jQg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 11/12] drm/panic: Move panic display code into helper library To: "Thomas Zimmermann" Cc: wsa+renesas@sang-engineering.com, imx@lists.linux.dev, ojeda@kernel.org, Frank.Li@kernel.org, intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260818125012.468092-12-tzimmermann@suse.de> References: <20260818125012.468092-1-tzimmermann@suse.de> <20260818125012.468092-12-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 18 Aug 2026 13:13:36 +0000 Message-Id: <20260818131337.702441F00A3D@smtp.kernel.org> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] Missing fallback stubs for `drm_panic_helper_init` and `drm_panic_h= elper_exit` cause link failure when `CONFIG_DRM_PANIC_HELPER` is disabled. - [Low] `DRM_KMS_HELPER` selects `DRM_PANIC_HELPER` without satisfying its = `DRM_TTM` dependency. -- --- Patch [11]: [PATCH 11/12] drm/panic: Move panic display code into helpe= r library --- commit 3d718c4f09d4c3ad0b378e7ca17f9b9b1d4d1627 Author: Thomas Zimmermann drm/panic: Move panic display code into helper library =20 This commit extracts panic display functionality from drm_panic.c into a new drm_panic_helper.c file. The KMS helper module is updated to link this new helper object, and relevant Kconfig and Makefile entries are added. > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 323422861e8f6..cdfd72d9a9c5e 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -45,6 +45,7 @@ config DRM_MIPI_DSI > config DRM_KMS_HELPER > tristate > depends on DRM > + select DRM_PANIC_HELPER if DRM_PANIC > select FB_CORE if DRM_FBDEV_EMULATION > help [ ... ] > @@ -130,6 +131,10 @@ config DRM_PANIC_SCREEN_QR_VERSION > Smaller QR code are easier to read, but will contain less debugging > data. Default is 40. > =20 > +config DRM_PANIC_HELPER > + bool > + depends on DRM_TTM [Severity: Low] Will this cause an unmet direct dependency warning in Kconfig? DRM_KMS_HELPER selects DRM_PANIC_HELPER, but it doesn't inherit or ensure=20 the DRM_TTM dependency is met. If a kernel is configured with DRM_KMS_HELPER and DRM_PANIC enabled, but without DRM_TTM, it might lead to Kconfig warnin= gs or a build failure. > diff --git a/drivers/gpu/drm/drm_kms_helper_common.c b/drivers/gpu/drm/dr= m_kms_helper_common.c > index 0c7550c0462b5..b5d5b469b4443 100644 > --- a/drivers/gpu/drm/drm_kms_helper_common.c > +++ b/drivers/gpu/drm/drm_kms_helper_common.c > @@ -27,6 +27,20 @@ > =20 > #include > =20 > +#include "drm_panic_internal.h" > + > +static int __init drm_kms_helper_init(void) > +{ > + return drm_panic_helper_init(); > +} > +module_init(drm_kms_helper_init); [ ... ] > diff --git a/drivers/gpu/drm/drm_panic_internal.h b/drivers/gpu/drm/drm_p= anic_internal.h > index c68d64c56e156..8aa91e80eb4dc 100644 > --- a/drivers/gpu/drm/drm_panic_internal.h > +++ b/drivers/gpu/drm/drm_panic_internal.h > @@ -52,4 +52,8 @@ static inline void drm_panic_lock(struct drm_device *de= v, unsigned long flags) { > static inline void drm_panic_unlock(struct drm_device *dev, unsigned lon= g flags) {} > #endif > =20 > +/* drm_panic_helper.c */ > +int drm_panic_helper_init(void); > +void drm_panic_helper_exit(void); > + [Severity: Low] Does this cause a link failure when CONFIG_DRM_PANIC_HELPER is disabled? The calls to drm_panic_helper_init() and drm_panic_helper_exit() in drm_kms_helper_common.c are unconditional. Without fallback static inline stubs in drm_panic_internal.h when the feature is disabled, it seems this will lead to unresolved external references during the linking phase. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260818125012.4680= 92-1-tzimmermann@suse.de?part=3D11