From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AFB0474247 for ; Tue, 18 Aug 2026 14:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787062282; cv=none; b=k8/V6hSfxu+Tc24rWYcBaYYaRaRfe5TN8qbDGloAACO1NM4tHgpqQNea9VcQTyeZcSfsr70qMALmSK2KzjVsN9Xq5m5sVmARHC2j2DPLluebq4bi+KAylvwVaNlJMHyKs0etiA74/aNijbmxdcCG7r8cAQBBOWvQqtlBBNYeyFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787062282; c=relaxed/simple; bh=FVx2/MBTsPCiR5O1d2m/Ofot4sfwNxdwCH1Jiq6p5Q0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g79TkbLUp7dZWCTkV26P0tVtp791BGcrwcfQUS76JQmfHdsr7X00ESA9C1tQB9rihy5WH3xmKQ/p/LbSgjMbMuzIEq18Igenko61KQhwRwUJZF6shmBtygnKNImP8dJj3SFiOrzOFG/6w/8yY4Pcf2x1Qx9g9MN6bvU0z8Wf61c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qS75BY9A; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qS75BY9A" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4957eefd361so36245295e9.1 for ; Tue, 18 Aug 2026 07:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787062279; x=1787667079; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gmJq5kdfed99Tj/tN4LBJ9nKv2g7oPVCdjFvdOWLjhQ=; b=qS75BY9A15vzJ0t/BfzqgnhrrUTlbCFBt5MFWSkNBajCdi9P9yBV97HbtkdJo85/m7 k25d4PIvaQYZ/nivYc4w4/vSUQ4J49xPnibkr97XkPJBBW8c4FOP3CHJ7ADOXrwTzmbT KtLjQ6xFrZUeKLK9WLJJ/v4RyoB+VDIt3nOqOrtkMSGF16owDdc81t17fx4k543yul7M YsANAxaSSEJm75gd9occMS7E+2S//yMZHSkHK2ualJNlDj8IPozXoN5Hh7YEC3S9Nq/Y J9qhi/WzxgrU5cfbJt1N3oD3e8bIuDodEKnX5BFsZ0fKhuQ/vauti+KbTz0KjzJfnKNw lv1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787062279; x=1787667079; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gmJq5kdfed99Tj/tN4LBJ9nKv2g7oPVCdjFvdOWLjhQ=; b=KG/EzW6JOfIRyrN7k539tNkh/cbnoWXVF5AxPJ4qrcwELE6jJpWHUSIoKi6HkiP3c8 nkqcHOo24wYmiQnwU4QMwaCi5tsMFLeeukztMTO14K+sMU8JLokHCiD+MUFas+QHknV5 JWBQVWdGX18vMkgYu5OvnCWjP6sHAOwMIz9+BtNia9yn8KPjYMx7LVb5/sQruD3muvqN VKw8ToG61RX5G1O8wC1xE6pHUTjYSTcLajbVA+QLBPczqk3vh5Pt3ntctCSZOU5SZ+fa TkkGSQaMV7Y2m4Vyu6/G7eSOBA8LU3QWK+5uEZw5Cn+o4DfJ0JzmaAFRnuaiGer3A9cg WVCA== X-Forwarded-Encrypted: i=1; AHgh+RoD2riHdbfjdTRCGBSzzlDqf94HNC00yJtmydu8YKCrGGio+DWn658VvGGoAITZFGqcME0t1Zd61IbJuaE=@vger.kernel.org X-Gm-Message-State: AOJu0YyADshWrr9FDlF/+oQH4ImzAEKnXmrKSIrGKvpcOn/p4LJ058mf rgNBtEfxtse+N3Cqw5HhOt8xod/4AdTNnLVjcLG7HmnJvSZ1AaSDfEum X-Gm-Gg: AR+sD13uHNe1zFHiIPsPO74Wmz3DK072GABagKPAl9EOU+rXDMtD/alosYRiOej18RD eHscsbxMIlw04LwuIl28SCKByd5cXnVZyoJO9Rm/nw4OB8lP72rrcJp79sV75fV0O2NH9nx96pX TtL3pQkYd0tHH2i8ZvYfCLfpP2RBHBheL3UjGoBV5Uks+nhHbPlggEqEYNxs1O+R4eCN1LtWtdO 9dMVLUtgV3axboiYIEjEMZz06idAlxRejTPyQ/Vkhfwz5+zrf4F7LX/MIc1QdI92AaPNskgIQ3M 3q32MedNNuCgyVNFcnQGNMv+XP+6IhHzc44dJJCJS3dB/7GoeqQXQDNaT0bHaSfMBatDMjhN9AL LkfA5EXIr3DslanPR5pr76RyAi61sMINkVAta8R9ADyYdHjgXJEbtJSvVZW4wvzuFaEjFyaTBBZ QYawokYyzMsKPDgqlxF/GCsqQElT9Y6s0FFNlZpcCjsfLp4FruotsaMN5opEcUYOZfmS+kKWQn7 QSCukVBXNUA1GgJCR+OjgXOp8AxybWsOQH0C5fP0y3YPMk8pU2y4w/RKiiGTrc9IkbTwDdC/PQf uQmUkDEpD5/mVIdfzkZ62sDytY8sHuykfOPJjqwTQK1rro0M527Ui3gzf202wptOVVTOf8/ZB5Y ILo0Rk7pX6z7G4ZlZudONT0QiOD2IBBbz7kqvgyI1aGjWsbAksl9Td9pXoHLOyAqG7btoTA== X-Received: by 2002:a05:600c:4614:b0:499:858f:2653 with SMTP id 5b1f17b1804b1-49987929193mr356449025e9.2.1787062279156; Tue, 18 Aug 2026 07:11:19 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5a31543sm13183148f8f.4.2026.08.18.07.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 07:11:18 -0700 (PDT) Date: Tue, 18 Aug 2026 16:11:15 +0200 From: Joshua Crofts To: "Maxwell Doose" Cc: "Jonathan Cameron" , "Andy Shevchenko" , "Andy Shevchenko" , "Sakari Ailus" , , , "Marius Cristea" , "David Lechner" , Nuno =?ISO-8859-1?Q?S=E1?= , "Andy Shevchenko" , "Tomasz Duszynski" , "Jean-Baptiste Maneyrol" Subject: Re: [PATCH v1 1/4] iio: light: Unshadow error codes in ->store() Message-ID: <20260818161115.000067a4@gmail.com> In-Reply-To: References: <20260813071912.2465208-1-andriy.shevchenko@linux.intel.com> <20260813071912.2465208-2-andriy.shevchenko@linux.intel.com> <20260817035414.496912f4@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 17 Aug 2026 14:12:56 -0500 "Maxwell Doose" wrote: ... > > Absolutely. One patch per driver for this and not more than 10 ish > > drivers in a series or out for review at a tiem. This stuff is still quite > > tricky to review, even with details on why each header change below the --- > > > > Also precursor patches for any significant reordering to put them in alphabetical > > + block for IIO headers just to make it easier to read the patch that cleans > > up what is included. > > > > I've done some of these as have many others. It's worthy work but slow to > > do! I'd suggest we leave it as a newbie task, but it requires more understanding > > than typical for one of those - so if you want to take it on (probably take > > a year or more to finish given review bandwidth!) then that would be most > > welcome. > > > > What we ought to do is start by removing all of the kernel.h inclusions > and then we can go into each individual driver and do IWYU on them. Not > sure if we want all of the IWYU stuff (including kernel.h removal) > rolled up into one patch per driver or if we want to split patches into > kernel.h removal and then IWYU (hopefully this time I can get iwyu-tool > setup so it won't be *as* gruelling). Or in the case of we leave it as a > newbie task maybe we just add it to the TODO (since this is probably one > of those things that happens over time when we revisit drivers). Well, removing kernel.h is essentially IWYU, as we have to include the actual used headers we were pulling in transitively. It should definitely be a task for newcomers, nevertheless as Jonathan says it's not exactly easy to do from the get go (and automating it with iwyu-tool can also be a headache). Also, I've had a pretty good experience with AI when it comes to verifying headers. I'll probably send a series removing it from some sensor type subdirectory, just to get the ball rolling? -- Kind regards, Joshua Crofts