All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@mailo.com>,
	"Peter Xu" <peterx@redhat.com>
Subject: [PATCH v2 2/9] hw/vexpress.c: Remove forced cast to u64
Date: Tue, 18 Aug 2026 13:20:05 -0400	[thread overview]
Message-ID: <20260818172012.3052821-3-peterx@redhat.com> (raw)
In-Reply-To: <20260818172012.3052821-1-peterx@redhat.com>

Now since ram_addr_t has switched to u64, remove the forced cast as not
needed.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/arm/vexpress.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c
index f26d8c6f8d..a6ce426356 100644
--- a/hw/arm/vexpress.c
+++ b/hw/arm/vexpress.c
@@ -363,16 +363,9 @@ static void a15_daughterboard_init(VexpressMachineState *vms,
     MachineState *machine = MACHINE(vms);
     MemoryRegion *sysmem = get_system_memory();
 
-    {
-        /* We have to use a separate 64 bit variable here to avoid the gcc
-         * "comparison is always false due to limited range of data type"
-         * warning if we are on a host where ram_addr_t is 32 bits.
-         */
-        uint64_t rsz = ram_size;
-        if (rsz > (30ULL * 1024 * 1024 * 1024)) {
-            error_report("vexpress-a15: cannot model more than 30GB RAM");
-            exit(1);
-        }
+    if (ram_size > (30ULL * 1024 * 1024 * 1024)) {
+        error_report("vexpress-a15: cannot model more than 30GB RAM");
+        exit(1);
     }
 
     /* RAM is from 0x80000000 upwards; there is no low-memory alias for it. */
-- 
2.54.0



  parent reply	other threads:[~2026-08-18 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 17:20 [PATCH v2 0/9] Remove 32bit support on system/user emulations Peter Xu
2026-08-18 17:20 ` [PATCH v2 1/9] system: Define ram_addr_t to be always uint64_t Peter Xu
2026-08-18 17:20 ` Peter Xu [this message]
2026-08-18 17:20 ` [PATCH v2 3/9] arm/mps: Remove 32bit define for MPS3_DDR_SIZE Peter Xu
2026-08-18 17:20 ` [PATCH v2 4/9] xen-mapcache: Remove 32bit support Peter Xu
2026-08-18 17:20 ` [PATCH v2 5/9] bsd-user: Remove 32bit host support in thunk_convert|print() Peter Xu
2026-08-18 17:20 ` [PATCH v2 6/9] linux-user: " Peter Xu
2026-08-18 17:20 ` [PATCH v2 7/9] arm/aspeed: Drop ASPEED_RAM_SIZE Peter Xu
2026-08-18 17:20 ` [PATCH v2 8/9] hw/arm/raspi4b: Drop board_rev for 32bit hosts Peter Xu
2026-08-18 17:20 ` [PATCH v2 9/9] machine: Remove 32bit limitation on ram size Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818172012.3052821-3-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@mailo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.