From: linuxtestproject.agent@gmail.com
To: Samir Mulani <samir@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.
Date: Tue, 18 Aug 2026 17:34:24 +0000 [thread overview]
Message-ID: <20260818173424.8975-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260818113032.41963-1-samir@linux.ibm.com>
Hi Samir,
On Tue, Aug 18, 2026, Samir Mulani wrote:
> sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.
> Fix all 'make check' warnings in hackbench.c to comply with the LTP
> coding style guidelines.
[Minor] Could create_worker() and reap_worker() be made static, or could the
claim above be narrowed? The affected directory's make check still reports
that both symbols have no prototype or library prefix and asks whether they
should be static.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-18 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 11:30 [LTP] [PATCH v5] sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c Samir Mulani
2026-08-18 17:34 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-22 11:40 [LTP] [PATCH v4] " Samir Mulani
2026-07-22 13:54 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818173424.8975-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=samir@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.