From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C081C5DF81 for ; Tue, 18 Aug 2026 17:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dRyYTIOIzC2lbyhm7o/lZKr7VOSAUdVppdL16MLNThs=; b=riJApyhI01qeO8 cmb2K3LiUJYRf01l/e+aRN7rtnlFw9+Oai71789wMlsydyjEJUVonh0biWkzyorkQamTk0onYLZaZ MBaKx/O4gxkfrE5D3oR658FwwIBPooUOeFUeuYroKX5f27oBN8mUNBIylPIIWe436KhGvr1v+r5Mx +4sVVVifdnVtRGFChUWCs+35MGq0pXXdzurAuBDHoF4ke31IRosWabfbp1lyhBGWm+7Z/j0YHilj6 PdkX5SHeyD0GIJWFi7zeQnIlq8k+1IDv/gQoG83sAw3wGzqFA5dkt6WMHBz4huBfFxCIUbUXzyxds esD1e149DFu9a5mMyRbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwNqz-00000008SIJ-1WzK; Tue, 18 Aug 2026 17:44:01 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwNqy-00000008SHc-25ZZ; Tue, 18 Aug 2026 17:44:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 93A906020E; Tue, 18 Aug 2026 17:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E0B1F000E9; Tue, 18 Aug 2026 17:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787075039; bh=coPuo6DlMjz6XUYFqtoCQOf7Mjzi2tu4MlwoML98W5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iG+fdD4TZ8co0TJrZnZRAMEzk+7DBr/xgnXnAamdru7pLg7eIfRerZuseVCPERot/ uQmkQ0ea2dIrg2Cddc82YAq6qdNQuuiicCZnbDZW1BpuclSShfQ041YsZRzbl03R4X gVUyjtID7cWOcCJu6AfPZW/h4AUUFOaVuaMqO3RQz6mgmFz1IR8PRAb+R/pKOtq2wJ EjTLQnFASoIoT9YEOzQ9Va0oeibBKHbEpMxFpjDYqoAutZEus9A43SYAEyccBL5EkL aLZQQD5+B6EiXSEJA7FKesUtTi9wmy/0UIptfDQrICKF/ek7PrcMBbtUmteqD7lz2I p++vIFK8T3kFg== Date: Tue, 18 Aug 2026 10:43:56 -0700 From: Eric Biggers To: Krzysztof Kozlowski Cc: Dawid Olesinski , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Diederik de Haas , Sebastian Reichel , Philipp Zabel , Conor Dooley , Corentin Labbe , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] crypto: rockchip: Add RK356x/RK3588 cryptographic offloader driver Message-ID: <20260818174356.GD2249@quark> References: <20260708175837.1718437-1-dawidro@gmail.com> <20260816194112.552100-1-dawidro@gmail.com> <20260816194112.552100-3-dawidro@gmail.com> <20260818-enigmatic-friendly-lizard-bc8aaf@quoll> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260818-enigmatic-friendly-lizard-bc8aaf@quoll> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2026 at 09:36:44AM +0200, Krzysztof Kozlowski wrote: > On Sun, Aug 16, 2026 at 08:39:45PM +0100, Dawid Olesinski wrote: > > Add a driver for the second-generation Rockchip cryptographic hardware > > accelerator found on RK3568 and RK3588 SoCs (compatible strings > > "rockchip,rk3568-crypto" and "rockchip,rk3588-crypto"). > > > > The hardware provides: > > - AES block cipher engine: ECB, CBC, and XTS modes, 128/192/256-bit > > keys. XTS hardware is limited to single-SG requests. > > - Hash engine: SHA-1, SHA-256, SHA-384, SHA-512, MD5, SM3. > > The hardware padding engine (HW_PAD) requires the total message > > length upfront and cannot maintain state across LLI descriptor > > boundaries, so multi-SG and unaligned requests are routed to a > > software fallback. > > - DMA engine: linked-list descriptor (LLI) based, with a 20-entry > > coherent descriptor table. > > Hardware encryption drivers are being removed or at least tried to be > removed multipled times, so would be nice to see here WHY this one > should be added. Well, it is the usual drivers/crypto/ pattern. It's being pushed as an "accelerator" despite the SoC already having ARMv8 CE which is almost certainly much faster (ARMv8 CE support is mentioned in the datasheet), MD5 (!) is being pushed for some reason, it's not properly tested, and no use case is described. These crypto driver submissions are basically spam at this point. Only thing that really saves them is that not many people have the hardware, so there tend not to be independent voices in the room besides the people pushing the driver as a checkbox feature. - Eric _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90E4AC5DF82 for ; Tue, 18 Aug 2026 17:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=coPuo6DlMjz6XUYFqtoCQOf7Mjzi2tu4MlwoML98W5o=; b=1U/LEp/kYvwbmR4xL6kLFKJuP4 HZHSsZ87LVkiqxpvopUZdkJckqep6RZU4otQ6iWgnH4bCywPP3K6/cn9syBgv/hlCgSxUF82jLyJD gklkTfvrOl82OrVJ2GQqgqdnn66oEf+OlS0PsUiku5RdrqfCWBfx6ntk+sK7qDn8ATPYwuYGFR1h7 hsSQSHdWwUqy1o/F9cHdceTEHqJVHhky57SPE1R0jDIBGLevaDVsp5Rtal7ljGHi7Wd1t+OFgwqaV cgpIKd46yHtp72yhIfv1ErGXhXbIrLQT1cfvupln9XpWFtudklgWjhnB2EyXCfyx9Tz8+7LSgh4pg 1qQCObJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwNqz-00000008SHx-0XtP; Tue, 18 Aug 2026 17:44:01 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwNqy-00000008SHc-25ZZ; Tue, 18 Aug 2026 17:44:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 93A906020E; Tue, 18 Aug 2026 17:43:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E0B1F000E9; Tue, 18 Aug 2026 17:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787075039; bh=coPuo6DlMjz6XUYFqtoCQOf7Mjzi2tu4MlwoML98W5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iG+fdD4TZ8co0TJrZnZRAMEzk+7DBr/xgnXnAamdru7pLg7eIfRerZuseVCPERot/ uQmkQ0ea2dIrg2Cddc82YAq6qdNQuuiicCZnbDZW1BpuclSShfQ041YsZRzbl03R4X gVUyjtID7cWOcCJu6AfPZW/h4AUUFOaVuaMqO3RQz6mgmFz1IR8PRAb+R/pKOtq2wJ EjTLQnFASoIoT9YEOzQ9Va0oeibBKHbEpMxFpjDYqoAutZEus9A43SYAEyccBL5EkL aLZQQD5+B6EiXSEJA7FKesUtTi9wmy/0UIptfDQrICKF/ek7PrcMBbtUmteqD7lz2I p++vIFK8T3kFg== Date: Tue, 18 Aug 2026 10:43:56 -0700 From: Eric Biggers To: Krzysztof Kozlowski Cc: Dawid Olesinski , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Diederik de Haas , Sebastian Reichel , Philipp Zabel , Conor Dooley , Corentin Labbe , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] crypto: rockchip: Add RK356x/RK3588 cryptographic offloader driver Message-ID: <20260818174356.GD2249@quark> References: <20260708175837.1718437-1-dawidro@gmail.com> <20260816194112.552100-1-dawidro@gmail.com> <20260816194112.552100-3-dawidro@gmail.com> <20260818-enigmatic-friendly-lizard-bc8aaf@quoll> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260818-enigmatic-friendly-lizard-bc8aaf@quoll> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2026 at 09:36:44AM +0200, Krzysztof Kozlowski wrote: > On Sun, Aug 16, 2026 at 08:39:45PM +0100, Dawid Olesinski wrote: > > Add a driver for the second-generation Rockchip cryptographic hardware > > accelerator found on RK3568 and RK3588 SoCs (compatible strings > > "rockchip,rk3568-crypto" and "rockchip,rk3588-crypto"). > > > > The hardware provides: > > - AES block cipher engine: ECB, CBC, and XTS modes, 128/192/256-bit > > keys. XTS hardware is limited to single-SG requests. > > - Hash engine: SHA-1, SHA-256, SHA-384, SHA-512, MD5, SM3. > > The hardware padding engine (HW_PAD) requires the total message > > length upfront and cannot maintain state across LLI descriptor > > boundaries, so multi-SG and unaligned requests are routed to a > > software fallback. > > - DMA engine: linked-list descriptor (LLI) based, with a 20-entry > > coherent descriptor table. > > Hardware encryption drivers are being removed or at least tried to be > removed multipled times, so would be nice to see here WHY this one > should be added. Well, it is the usual drivers/crypto/ pattern. It's being pushed as an "accelerator" despite the SoC already having ARMv8 CE which is almost certainly much faster (ARMv8 CE support is mentioned in the datasheet), MD5 (!) is being pushed for some reason, it's not properly tested, and no use case is described. These crypto driver submissions are basically spam at this point. Only thing that really saves them is that not many people have the hardware, so there tend not to be independent voices in the room besides the people pushing the driver as a checkbox feature. - Eric