All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Samir Mulani <samir@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget
Date: Tue, 18 Aug 2026 19:29:56 +0000	[thread overview]
Message-ID: <20260818192956.8788-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260818131800.42931-1-samir@linux.ibm.com>

Hi Samir,

On Tue, Aug 18, 2026, Samir Mulani wrote:
> mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget

> +	shm_id_1 = SAFE_SHMGET(shmkey, shm_size,
> +			      SHM_HUGETLB | IPC_CREAT | IPC_EXCL | SHM_RW);

> -		tst_res(TFAIL | TTERRNO, "shmget failed unexpectedly "
> -				"- expect errno=ENOSPC, got");
> +		tst_res(TFAIL | TTERRNO,
> +			"shmget failed unexpectedly - expect errno=ENOSPC, got");

Severity: medium

Could the checkpatch-only changes be moved to a separate patch? The
SAFE_SHMGET() conversion is a behavioral API cleanup, while hugeshmget03
contains only independent message-formatting changes. LTP requires each
patch to contain one logical change.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2026-08-18 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 13:18 [LTP] [PATCH v3] mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget Samir Mulani
2026-08-18 19:29 ` linuxtestproject.agent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818192956.8788-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=samir@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.