From: Gabriel Rondon <grondon@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Matti Vaittinen" <mazziesaccount@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: kionix-kx022a: use iio_push_to_buffers_with_ts()
Date: Tue, 18 Aug 2026 22:51:18 +0100 [thread overview]
Message-ID: <20260818215118.52664-1-grondon@gmail.com> (raw)
In-Reply-To: <20260818171657.7c1af7b3@jic23-huawei>
On Tue, 18 Aug 2026 17:16:57 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> Why do we have both scan and buffer? The kx022a_trigger_handler()
> could just as easily use scan (which is the cleaner solution here)
>
> That leaves get_axis which uses st->buffer as well. Whilst it is a little
> ugly, that can just use the first channel of scan as well.
>
> If you are happy to do so could you make that change as a precursor
> to this set?
Happy to. v2 splits it into a precursor that drops buffer and routes
both the one-shot read and the triggered handler through scan (moving
the IIO_DMA_MINALIGN alignment onto scan), then the conversion on top.
Thanks,
Gabriel
prev parent reply other threads:[~2026-08-18 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 15:56 [PATCH] iio: accel: kionix-kx022a: use iio_push_to_buffers_with_ts() Gabriel Rondon
2026-08-18 16:16 ` Jonathan Cameron
2026-08-18 21:51 ` Gabriel Rondon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818215118.52664-1-grondon@gmail.com \
--to=grondon@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.