All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: oe-kbuild-all@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, arm@kernel.org
Subject: [soc:board-remove 182/217] drivers/gpio/gpio-max732x.c:604:29: warning: variable 'node' set but not used
Date: Wed, 19 Aug 2026 00:59:10 +0800	[thread overview]
Message-ID: <202608190030.YSmZfhvZ-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove
head:   057394422bc04420585b2790b230d8a1f350ace8
commit: 387fb9a6dc61a05c81abec13a03b8b95d0d05471 [182/217] gpio: max732x: remove pdata based probing
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260819/202608190030.YSmZfhvZ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260819/202608190030.YSmZfhvZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608190030.YSmZfhvZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpio/gpio-max732x.c: In function 'max732x_probe':
>> drivers/gpio/gpio-max732x.c:604:29: warning: variable 'node' set but not used [-Wunused-but-set-variable=]
     604 |         struct device_node *node;
         |                             ^~~~


vim +/node +604 drivers/gpio/gpio-max732x.c

bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  600  
8ac813f7e663bcf drivers/gpio/gpio-max732x.c Uwe Kleine-König    2022-11-18  601  static int max732x_probe(struct i2c_client *client)
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  602  {
8ac813f7e663bcf drivers/gpio/gpio-max732x.c Uwe Kleine-König    2022-11-18  603  	const struct i2c_device_id *id = i2c_client_get_device_id(client);
43c4bcf9425ef59 drivers/gpio/gpio-max732x.c Sam Protsenko       2015-01-13 @604  	struct device_node *node;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  605  	struct max732x_chip *chip;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  606  	struct i2c_client *c;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  607  	uint16_t addr_a, addr_b;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  608  	int ret, nr_port;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  609  
43c4bcf9425ef59 drivers/gpio/gpio-max732x.c Sam Protsenko       2015-01-13  610  	node = client->dev.of_node;
43c4bcf9425ef59 drivers/gpio/gpio-max732x.c Sam Protsenko       2015-01-13  611  
43c4bcf9425ef59 drivers/gpio/gpio-max732x.c Sam Protsenko       2015-01-13  612  	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  613  	if (chip == NULL)
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  614  		return -ENOMEM;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  615  	chip->client = client;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  616  
387fb9a6dc61a05 drivers/gpio/gpio-max732x.c Arnd Bergmann       2026-08-07  617  	nr_port = max732x_setup_gpio(chip, id);
58383c78425e4ee drivers/gpio/gpio-max732x.c Linus Walleij       2015-11-04  618  	chip->gpio_chip.parent = &client->dev;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  619  
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  620  	addr_a = (client->addr & 0x0f) | 0x60;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  621  	addr_b = (client->addr & 0x0f) | 0x50;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  622  
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  623  	switch (client->addr & 0x70) {
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  624  	case 0x60:
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  625  		chip->client_group_a = client;
5535cb681c38bda drivers/gpio/max732x.c      Axel Lin            2010-05-26  626  		if (nr_port > 8) {
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  627  			c = devm_i2c_new_dummy_device(&client->dev,
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  628  						      client->adapter, addr_b);
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  629  			if (IS_ERR(c)) {
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  630  				dev_err(&client->dev,
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  631  					"Failed to allocate I2C device\n");
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  632  				return PTR_ERR(c);
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  633  			}
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  634  			chip->client_group_b = chip->client_dummy = c;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  635  		}
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  636  		break;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  637  	case 0x50:
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  638  		chip->client_group_b = client;
5535cb681c38bda drivers/gpio/max732x.c      Axel Lin            2010-05-26  639  		if (nr_port > 8) {
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  640  			c = devm_i2c_new_dummy_device(&client->dev,
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  641  						      client->adapter, addr_a);
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  642  			if (IS_ERR(c)) {
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  643  				dev_err(&client->dev,
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  644  					"Failed to allocate I2C device\n");
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  645  				return PTR_ERR(c);
f3a049e784b337e drivers/gpio/gpio-max732x.c Zhouyang Jia        2018-06-12  646  			}
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  647  			chip->client_group_a = chip->client_dummy = c;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  648  		}
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  649  		break;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  650  	default:
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  651  		dev_err(&client->dev, "invalid I2C address specified %02x\n",
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  652  				client->addr);
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  653  		return -EINVAL;
f561b4230cec901 drivers/gpio/gpio-max732x.c Krzysztof Kozlowski 2014-03-06  654  	}
f561b4230cec901 drivers/gpio/gpio-max732x.c Krzysztof Kozlowski 2014-03-06  655  
f561b4230cec901 drivers/gpio/gpio-max732x.c Krzysztof Kozlowski 2014-03-06  656  	if (nr_port > 8 && !chip->client_dummy) {
f561b4230cec901 drivers/gpio/gpio-max732x.c Krzysztof Kozlowski 2014-03-06  657  		dev_err(&client->dev,
f561b4230cec901 drivers/gpio/gpio-max732x.c Krzysztof Kozlowski 2014-03-06  658  			"Failed to allocate second group I2C device\n");
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  659  		return -ENODEV;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  660  	}
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  661  
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  662  	mutex_init(&chip->lock);
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  663  
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  664  	ret = max732x_readb(chip, is_group_a(chip, 0), &chip->reg_out[0]);
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  665  	if (ret)
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  666  		return ret;
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  667  	if (nr_port > 8) {
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  668  		ret = max732x_readb(chip, is_group_a(chip, 8), &chip->reg_out[1]);
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  669  		if (ret)
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  670  			return ret;
78de5d522032245 drivers/gpio/gpio-max732x.c Nicholas Krause     2015-08-18  671  	}
a80a0bbee49872c drivers/gpio/max732x.c      Marc Zyngier        2010-05-26  672  
bb58a47a120b888 drivers/gpio/gpio-max732x.c Linus Walleij       2020-07-27  673  	ret = max732x_irq_setup(chip, id);
a80a0bbee49872c drivers/gpio/max732x.c      Marc Zyngier        2010-05-26  674  	if (ret)
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  675  		return ret;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  676  
bb58a47a120b888 drivers/gpio/gpio-max732x.c Linus Walleij       2020-07-27  677  	ret = devm_gpiochip_add_data(&client->dev, &chip->gpio_chip, chip);
2674700c4c0ec3b drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  678  	if (ret)
375b94246761816 drivers/gpio/gpio-max732x.c Bartosz Golaszewski 2019-05-21  679  		return ret;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  680  
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  681  	i2c_set_clientdata(client, chip);
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  682  	return 0;
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  683  }
bbcd6d543de335b drivers/gpio/max732x.c      Eric Miao           2008-07-25  684  

:::::: The code at line 604 was first introduced by commit
:::::: 43c4bcf9425ef596f9651bd0c647065dc5e9ad50 gpio: max732x: Add device tree support

:::::: TO: Semen Protsenko <semen.protsenko@globallogic.com>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-18 17:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608190030.YSmZfhvZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.