From: svav2021@gmail.com
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Arav Verma <svav2021@gmail.com>
Subject: [PATCH 2/2] platform/x86: intel: wmi: Remove redundant callbacks
Date: Tue, 18 Aug 2026 23:42:51 -0500 [thread overview]
Message-ID: <20260819044313.335043-2-svav2021@gmail.com> (raw)
In-Reply-To: <20260819044313.335043-1-svav2021@gmail.com>
From: Arav Verma <svav2021@gmail.com>
Removed redundant .probe and .remove callbacks from
wmi_driver struct, as they were print-only and unnecessary
---
drivers/platform/x86/intel/wmi/sbl-fw-update.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
index cfef71f4f3284..7e07cfab227c8 100644
--- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c
+++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
@@ -93,18 +93,6 @@ static struct attribute *firmware_update_attrs[] = {
};
ATTRIBUTE_GROUPS(firmware_update);
-static int intel_wmi_sbl_fw_update_probe(struct wmi_device *wdev,
- const void *context)
-{
- dev_info(&wdev->dev, "Slim Bootloader signaling driver attached\n");
- return 0;
-}
-
-static void intel_wmi_sbl_fw_update_remove(struct wmi_device *wdev)
-{
- dev_info(&wdev->dev, "Slim Bootloader signaling driver removed\n");
-}
-
static const struct wmi_device_id intel_wmi_sbl_id_table[] = {
{ .guid_string = INTEL_WMI_SBL_GUID },
{}
@@ -116,8 +104,6 @@ static struct wmi_driver intel_wmi_sbl_fw_update_driver = {
.name = "intel-wmi-sbl-fw-update",
.dev_groups = firmware_update_groups,
},
- .probe = intel_wmi_sbl_fw_update_probe,
- .remove = intel_wmi_sbl_fw_update_remove,
.id_table = intel_wmi_sbl_id_table,
.no_singleton = true,
};
--
2.47.3
prev parent reply other threads:[~2026-08-19 4:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 4:42 [PATCH 1/2] platform/x86: intel: wmi: Use sysfs_emit in sbl-fw-update svav2021
2026-08-19 4:42 ` svav2021 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819044313.335043-2-svav2021@gmail.com \
--to=svav2021@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.