All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Cain <brian.cain@oss.qualcomm.com>
To: qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
	Brian Cain <brian.cain@oss.qualcomm.com>
Subject: [PATCH 0/2] Hexagon: fix icinva
Date: Tue, 18 Aug 2026 21:53:37 -0700	[thread overview]
Message-ID: <20260819045339.3661773-1-brian.cain@oss.qualcomm.com> (raw)

icinva (icache invalidate addr) instruction was a nop, but this behavior
is not correct for userspace.

Also note that this checkpatch issue was bypassed because I believe
it's appropriate/acceptable to check the "guest" page size in a TCG test
case.

    Patch 1/2 has no obvious style problems and is ready for submission.
    2/2 Checking commit ea94abbfc875 (tests/tcg/hexagon: add icinva test)
    ERROR: use qemu_real_host_page_size() instead of sysconf(_SC_PAGESIZE)
    #74: FILE: tests/tcg/hexagon/icinva.c:56:
    +    long pagesize = sysconf(_SC_PAGESIZE);

Brian Cain (2):
  target/hexagon: invalidate translated code for user icinva
  tests/tcg/hexagon: add icinva test

 target/hexagon/gen_tcg.h          |  9 ++++
 target/hexagon/helper.h           |  4 ++
 target/hexagon/op_helper.c        | 15 +++++++
 target/hexagon/translate.c        |  3 ++
 tests/tcg/hexagon/icinva.c        | 71 +++++++++++++++++++++++++++++++
 tests/tcg/hexagon/Makefile.target |  2 +
 6 files changed, 104 insertions(+)
 create mode 100644 tests/tcg/hexagon/icinva.c

-- 
2.34.1


             reply	other threads:[~2026-08-19  4:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  4:53 Brian Cain [this message]
2026-08-19  4:53 ` [PATCH 1/2] target/hexagon: invalidate translated code for user icinva Brian Cain
2026-08-20 18:37   ` Pierrick Bouvier
2026-08-20 19:00     ` Brian Cain
2026-08-20 19:10       ` Pierrick Bouvier
2026-08-20 23:40       ` Richard Henderson
2026-08-19  4:53 ` [PATCH 2/2] tests/tcg/hexagon: add icinva test Brian Cain
2026-08-20 19:11   ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819045339.3661773-1-brian.cain@oss.qualcomm.com \
    --to=brian.cain@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.