From: Christoph Hellwig <hch@lst.de>
To: Chuyf26 <Chuyf26@linux.alibaba.com>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: verify the hostid when looking up a controller
Date: Wed, 19 Aug 2026 07:51:46 +0200 [thread overview]
Message-ID: <20260819055146.GB326@lst.de> (raw)
In-Reply-To: <20260818162551.1AFD768CFE@verein.lst.de>
On Tue, Aug 18, 2026 at 06:25:51PM +0200, Chuyf26 wrote:
> nvmet_ctrl_find_get() matches controllers by cntlid and hostnqn only.
> The hostnqn is not a secret: any host that can reach the subsystem can
> put an arbitrary NQN into its connect data. A malicious host knowing
> or guessing the NQN and controller ID of another host (controller IDs
> are allocated sequentially) can therefore attach its queues to that
> host's controller, issue commands on its behalf, or disturb its I/O by
> tearing down the shared controller state.
Yes.
> Also require the hostid from the connect data to match the controller's
> hostid. The hostid identifies the host installation and is generated
> locally, so it cannot be chosen by an attacker to impersonate another
> host. Controllers that were created without a hostid keep the old
> behaviour.
Of course it can. Please don't send completely useless LLM garbage,
thank you!
next parent reply other threads:[~2026-08-19 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260818162551.1AFD768CFE@verein.lst.de>
2026-08-19 5:51 ` Christoph Hellwig [this message]
2026-08-18 16:29 [PATCH] nvmet: verify the hostid when looking up a controller Chuyf26
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819055146.GB326@lst.de \
--to=hch@lst.de \
--cc=Chuyf26@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.