All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: James <aslan.jnn@gmail.com>
Cc: Raju Rangoju <Raju.Rangoju@amd.com>,
	Prashanth Kumar K R <PrashanthKumar.K.R@amd.com>,
	netdev@vger.kernel.org, Thomas.Lendacky@amd.com
Subject: Re: [PATCH net] net: amd-xgbe: support receiving packets with bad FCS
Date: Wed, 19 Aug 2026 10:01:51 +0100	[thread overview]
Message-ID: <20260819090151.GO265046@horms.kernel.org> (raw)
In-Reply-To: <20260819023602.10387-1-aslan.jnn@gmail.com>

On Wed, Aug 19, 2026 at 12:36:01PM +1000, James wrote:
> On Fri, Aug 14, 2026 at 11:09:16AM +0100, Simon Horman <horms@kernel.org> wrote:
> > FWIW, I lean towards this being an enhancement for net-next without
> > a Fixes tag. Rather than a fix.
> 
> Hi Simon, thank you for the review! Apologise for the late reply as I was
> unwell last week.
> 
> My rationale for targeting `net` was that the driver currently accepts bad
> FCS frames by default, which I believe should be an incorrect existing behavior.
> The `NETIF_F_RXALL` I added is intended to preserve access to that behavior
> only when a user explicitly requests it.
> 
> With that said, I understand that exposing the `rx-all` control may make
> this better suited for `net-next`. Do you prefer that I respin this as a
> `net-next` patch (when it opens later this month), or do you think the
> default-behavior correction justifies keeping it in `net`?

I do lean towards this being for net-next. But if you feel strongly
that it is for net, I won't push the matter any further.

BTW, net-next is currently closed. So if you do post it for net-next you
will need to wait for it to reopen around 31st August.

  reply	other threads:[~2026-08-19  9:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  9:16 [PATCH net] net: amd-xgbe: support receiving packets with bad FCS James
2026-08-14 10:09 ` Simon Horman
2026-08-19  2:36   ` James
2026-08-19  9:01     ` Simon Horman [this message]
2026-08-17 23:32 ` Jakub Kicinski
2026-08-19  6:31   ` James
2026-08-19  9:16 ` [PATCH net v2] " James
2026-08-19 11:43 ` [PATCH net] " David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819090151.GO265046@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=PrashanthKumar.K.R@amd.com \
    --cc=Raju.Rangoju@amd.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=aslan.jnn@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.