All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Avinesh Kumar <avinesh.kumar@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] openposix: timer_*/speculative: Skip untestable optional behavior on Linux
Date: Wed, 19 Aug 2026 10:33:10 +0000	[thread overview]
Message-ID: <20260819103310.39525-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260819093210.24342-1-avinesh.kumar@suse.com>

Hi Avinesh,

On Wed, 19 Aug 2026, Avinesh Kumar wrote:
> openposix: timer_*/speculative: Skip untestable optional behavior on Linux

> +#ifdef __linux__
> +	printf("Linux does not implement this optional behavior\n");
> +	return PTS_UNSUPPORTED;
> +#else

Could these branches be removed from all eleven tests? Linux 7.2 uses
scoped_timer_get_or_fail() to return -EINVAL for invalid timer IDs in
timer_gettime(), timer_getoverrun(), timer_settime(), and timer_delete().
The installed man pages document the same EINVAL result.

More directly, every pre-patch test reports errno == EINVAL and returns
PTS_PASS when built and run on Linux. The platform check therefore replaces
working coverage with PTS_UNSUPPORTED, and the quoted runtime message is not
accurate.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2026-08-19 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19  9:31 [LTP] [PATCH v2] openposix: timer_*/speculative: Skip untestable optional behavior on Linux Avinesh Kumar via ltp
2026-08-19 10:33 ` linuxtestproject.agent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819103310.39525-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=avinesh.kumar@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.