From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E235134B697 for ; Wed, 19 Aug 2026 12:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787141853; cv=none; b=pO3HPoxAqgGEoUy/HKygWBw2w7BE2VqYxv0cV9iE6Y184fRPHfaDpFQT67SJBhjtScbuLP3nS//lrnfwamkHjDpiKLUQjej8Q7xz4rtBW3buB3AYw6EEcHzpncPru2qSO8MBMkj49oZR/N2U1aWwkwO5lO9lqb/JCrWzXyrmFWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787141853; c=relaxed/simple; bh=QLVmhApoIdTSnG+xl7FWKcVJjdtidrk3TLZpK5AFcnc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cI1GAKIreb6U0/3uFFXuALeTbsUmqByzRosh6ZbkQriTj9I5bobqlaYpoVa4G+HbmlCXuGgITByDql9Mfq3Ri3Yrvu2WNfQNXkwncR+SdYgqLAZSkwikvwARlJFHwsOYNGISNksbBv4ZEaMO/QM5zQSiqYadOdI8zicy3crJeLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=neXAdWA9; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="neXAdWA9" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e58034d05so853963a91.2 for ; Wed, 19 Aug 2026 05:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787141851; x=1787746651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Ky3eaerp2FIi8m89t9kDf7IwmRQ42625cuWkd+thIcA=; b=neXAdWA90VIXjiTTtqCF+q3jMEY2JtTMlER0VWFbb6sOcswi7keb6W1hI68KgOu89K wYEwPpJil8ThzAPobPk6P9hQskjp/BgjVGXG789RdESTOuN1qUYtYG0E/GQ31sZxbrE+ nQpiUMX9qAp+iqI/Ll23RE0LvbqbNBSPDIMx2E92Pn5EzZNqMBVKp5TRFscn513z0Xo6 eKr6eEo6ZcbQofmaTdNuw2I1h+v4x9pWpcnNTwJCyCCm8NAbZ0O4e0pixEN10Ve1xvzi DDQDKvs+BLerOahbl06XEROHbhd7dqZps0O+sTfZyNGMH3BgM6KT/h2BndVSlID1o8wR p3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787141851; x=1787746651; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ky3eaerp2FIi8m89t9kDf7IwmRQ42625cuWkd+thIcA=; b=WSOAAw1O4mVrMSE+0TEzvCzBN2rlPEXqIgPi7Wp4a5YSA1JOevAYZTyTEz7n2kf947 +DW3ggLtU6mjlWwd308q4B7R/pkJ2ywT6reETTdsEZhjKl7v0tIwoQQgLA3HLBdRxzRT CbRhOLE4AiN/RL8kvQ09lnw/osBbj8aM+TM/L+CYJZk1GG/GgNtJ0S9teXyIjJnSyyLK Teax7bbYVqW/CcglHz3pO6metquidXX2JsmXHLPpk0cNSvDznviIqG+aeLJbb8PR1pY4 1qWCwyvicEYJjKRL8FkEInQOx7AwtMYUHl2kZvx3PkOowT5S8+m4PgOwbY/6n446mNmF 0L6w== X-Forwarded-Encrypted: i=1; AHgh+RrDF9AdQb7Pz7R+GN0IrAr5Fsm6jGB4pH3WV/rpTZsXdgrWcvMV0tbg7XYXVdFOseAT0sWtL7VlP+X/PrY=@vger.kernel.org X-Gm-Message-State: AFuF++mPri5/FrdFChLea1yWkzNTYGDIbIycl2IvGEyIX6Tkq32St6f6 Krlz0EqZNb3DwYKkFhAdU4kACyLteVzSO44t1gFsrV6S60FmXyz+eQ0g X-Gm-Gg: AR+sD12HSjazB0+Zyq5f3Y7aBJUNuqEiou2Vd9JI7M8Xx5a108NyBkPuMcZ+SYxOvdd gMz/YJAbX2Zid+pkxbNKL8hLZ8b4rW1i9hqEgtQXnDQz6kmzLA3enrMoR8Q+gnyiXpwqMhRFGKX uSRWrFs3wqhWx1x8u4x3zS2WgnrbdvOWSa2i5wig9ELKuwax47pNWUh2aHQAGVRJePm3b9doNeU +uhdVlVik7hELWC+msaqW6B2Bu/bGkLmmq/5oQorwaDRyfmL5j+FSL5iAoyztC13IdjtgFue6ML VnVMZJwn9asZpxa99iuPJkYuWj3qsnEhCxyhoPaNgQG63ztvSerT3et4wT/uu5BeiCzVm5pnbwH l7dgdCBBcBaRpK+Ywb0kV40ZljN+2flSX0NZghHKvDTRzKiKnrk8xb5mFkvAxQzx7jvSV3jwi/0 y0xbMIrxBuFJwDNXG1HOnW+XqScCCoeScs/6vmolqE82SLFtzlRa7e4wzpX5ap/1I2fKc= X-Received: by 2002:a17:90b:4d81:b0:37d:f206:a2ac with SMTP id 98e67ed59e1d1-39580a7c832mr8254013a91.7.1787141850868; Wed, 19 Aug 2026 05:17:30 -0700 (PDT) Received: from Anshuman ([103.106.200.63]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ad6060asm12607295c88.6.2026.08.19.05.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 05:17:30 -0700 (PDT) From: Anshuman To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes Cc: Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman Subject: [PATCH] selftests/mm: check stat() return value in khugepaged get_finfo() Date: Wed, 19 Aug 2026 17:44:26 +0530 Message-ID: <20260819121426.49500-1-anshumantewari123@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit get_finfo() calls stat() to get metadata about the target directory, but never checks the return value. On failure, stat() returns -1 and leaves path_stat unmodified, so path_stat.st_mode may contain uninitialized stack data. The code then checks S_ISDIR(path_stat.st_mode) against this potentially garbage value. This can produce a misleading "Not a directory" error when the real problem is a nonexistent or inaccessible path, or, in the worst case, the check could pass by chance on garbage data and let the function continue using an invalid path_stat for the rest of its logic. Check the return value and fail with a clear error message if stat() fails, matching the error-handling style already used for statfs() and read_file() later in the same function. Signed-off-by: Anshuman --- tools/testing/selftests/mm/khugepaged.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c index 10e8dedcb..2240a9b4f 100644 --- a/tools/testing/selftests/mm/khugepaged.c +++ b/tools/testing/selftests/mm/khugepaged.c @@ -121,7 +121,8 @@ static void get_finfo(const char *dir) char *str, *end; finfo.dir = dir; - stat(finfo.dir, &path_stat); + if (stat(finfo.dir, &path_stat)) + ksft_exit_fail_perror("stat()"); if (!S_ISDIR(path_stat.st_mode)) ksft_exit_fail_msg("%s: Not a directory (%s)\n", __func__, finfo.dir); if (snprintf(finfo.path, sizeof(finfo.path), "%s/" TEST_FILE, -- 2.55.0