From: opensource@fvhovell.nl
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Frederik van Hövell" <frederik@fvhovell.nl>
Subject: [PATCH 2/4] hw/misc/bcm2835_property: fix RPI_FWREQ_GET_FIRMWARE_REVISION response
Date: Wed, 19 Aug 2026 14:27:00 +0200 [thread overview]
Message-ID: <20260819122702.54173-3-opensource@fvhovell.nl> (raw)
In-Reply-To: <20260819122702.54173-1-opensource@fvhovell.nl>
From: Frederik van Hövell <frederik@fvhovell.nl>
The returned value for revision is interpreted as an unix epoch timestamp after year 2000 by EDK2 for RPi3/4 boards.
EDK2 firmware uses the revision to show as human-readable 'year.month', and asserted to have year between 2000 and 2255 (both inclusive).
See [PlatformSmbiosDxe.c](https://github.com/tianocore/edk2-platforms/blob/master/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c#L763).
Signed-off-by: Frederik van Hövell <frederik@fvhovell.nl>
---
hw/misc/bcm2835_property.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index a90c7e6c863..a705e44b1fe 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -52,7 +52,8 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
case RPI_FWREQ_PROPERTY_END:
break;
case RPI_FWREQ_GET_FIRMWARE_REVISION:
- stl_le_phys(&s->dma_as, value + 12, 346337);
+ // Use timestamp of first released Raspberry Pi as minimum 'revision': 2012-02-29T00:00:00.000Z
+ stl_le_phys(&s->dma_as, value + 12, 1330473600);
resplen = 4;
break;
case RPI_FWREQ_GET_BOARD_MODEL:
--
2.55.0
next prev parent reply other threads:[~2026-08-19 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 12:26 [PATCH 0/4] Support booting modern EDK2 on raspi3b board opensource
2026-08-19 12:26 ` [PATCH 1/4] hw/misc/bcm2835_property: fix RPI_FWREQ_FRAMEBUFFER_ALLOCATE response opensource
2026-08-19 12:27 ` opensource [this message]
2026-08-19 12:27 ` [PATCH 3/4] hw/arm/raspi: implement booting firmware at 0x0 using -bios on boards 3ap, 3b and 4b opensource
2026-08-19 12:27 ` [PATCH 4/4] tests/functional/aarch64/test_raspi3: update firmware to v1.52 opensource
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819122702.54173-3-opensource@fvhovell.nl \
--to=opensource@fvhovell.nl \
--cc=f4bug@amsat.org \
--cc=frederik@fvhovell.nl \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.